Repository navigation
fix: publish serial event and integrated run output - #196
Open
zhaozhiwen wants to merge 1 commit into
Open
zhaozhiwen wants to merge 1 commit into
zhaozhiwen wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serial generated count was zero and integrated dose was absent.
Let sequential execution own both output roles, keep event files distinct from run files, and merge its accumulated data once.
Validation: Serial and one/two-worker MT output, mixed generated/dose data, and deterministic 40/4=10 normalization. Regression failed against the original implementation and passed with the focused fix. Combined source build/install and all 44 affected regressions passed. The 32-example sweep retained its 19/32 baseline with no new failing examples.
Closes #187.
Verification on 2026-11-15: all 44 selected affected regressions passed again on the combined nine-fix source. Each issue also has a separate failing-original/passing-fixed regression. These PR branches each contain only their own fix; shared-file conflicts may need resolving as other fixes merge. No clean full-project-suite claim: the broader source-example baseline remains 19/32, with no newly failing examples in the combined sweep.
Run-lifecycle sequence: submit this fix first, then the separate repeated-run output fix (#188), then integrated JSON validation (#192).