Skip to content

fix: normalize untracked Lund generated-particle units - #198

Open
zhaozhiwen wants to merge 1 commit into
gemc:mainfrom
zhaozhiwen:fix/190-lund-units
Open

zhaozhiwen wants to merge 1 commit into
gemc:mainfrom
zhaozhiwen:fix/190-lund-units

Conversation

@zhaozhiwen

Copy link
Copy Markdown
Collaborator

Type-0 1 GeV row exported p=1 and cm vertex coordinates.

Convert source-only Lund records from GeV/cm into the same internal momentum/length units as propagated records.

Validation: Mixed tracked/untracked rows, zero momentum, negative vertices and angles, consistent generated banks in JSON/CSV/ROOT. Regression failed against the original implementation and passed with the focused fix. Combined source build/install and all 44 affected regressions passed. The 32-example sweep retained its 19/32 baseline with no new failing examples.

Closes #190.

Verification on 2026-11-15: all 44 selected affected regressions passed again on the combined nine-fix source. Each issue also has a separate failing-original/passing-fixed regression. These PR branches each contain only their own fix; shared-file conflicts may need resolving as other fixes merge. No clean full-project-suite claim: the broader source-example baseline remains 19/32, with no newly failing examples in the combined sweep.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated Lund records mix GeV and cm with MeV and mm depending on particle tracking type

1 participant