Skip to content

Prices: plans.json holds each plan's own price; extra prices from a secret - #256

Merged
MeharPro merged 1 commit into
mainfrom
chore/private-prices
Nov 17, 2026
Merged

MeharPro merged 1 commit into
mainfrom
chore/private-prices

Conversation

@MeharPro

Copy link
Copy Markdown
Contributor

billing/plans.json now holds each plan's own price only: Pro is US$50 a developer a month under genclass_team_monthly. Any other price for a plan comes from the Worker secret PLANS_PRIVATE (src/plans.ts usePrivatePlans), and scripts/stripe-setup.mjs reads the same JSON from GENCLASS_PLANS_PRIVATE. Neither is committed. Emails and other messages without a visitor show the plan's own price. genclass 0.3.12 shows that price before sign-in.

Checks: telemetry-worker vitest 907/907 (new test/private-prices.test.ts and test/stripe-setup-private.test.ts, with made-up values); packages/cli build + vitest 215/215.

🤖 Generated with Claude Code

…e from a Worker secret

Pro is US$50 a developer a month under its usual lookup key (genclass_team_monthly). Any other
price for a plan is read from the Worker secret PLANS_PRIVATE (src/plans.ts usePrivatePlans,
called by handle()), and scripts/stripe-setup.mjs reads the same JSON from GENCLASS_PLANS_PRIVATE;
neither is committed. Messages with no buyer in front of them show the plan's own price. The
genclass command's text before sign-in shows the plan's own price too (0.3.12).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@genclass-dev

genclass-dev Bot commented Nov 17, 2026

Copy link
Copy Markdown

GenClass runtime review

2 findings in this pull request's tests at dd48836 · 2 reproducible · 5 tests read

# Status Finding Test Seen
1 New Witness, overwrote-newer · GET /api/search [chromium] search.spec.ts > search > buggy page: results of the last query 2 of 2 seeds, reproducible
2 New Witness, overwrote-newer · GET /api/search search.spec.ts > search > buggy page: results of the last query 5 of 5 seeds, reproducible

Reply @genclass-dev replay 1 for the steps to reproduce a finding, or @genclass-dev fix 1 for a brief a coding agent can work from.

The race report, test by test

Race report

2 signatures in 2 tests, 2 reproducible (flagged in 2 or more seeds of the same test) · 19 files read · mode observe

signatures reproducible
Duplicate submits 0 0
Stale responses 0 0
Failing endpoints 0 0
Other detections 0 0
Witnesses (facts measured without the model) 2 2
[chromium] search.spec.ts > search > buggy page: results of the last query

2 seeds (1, 2) · 1 signature · chaos: latency 0–600 ms, reorder

Witnesses (facts measured without the model)

  • Reproducible: 2 of 2 seeds (1, 2) · GET /api/search · witness:overwrote-newer

    The response of GET /api/search#​1 wrote search.results over what newer GET /api/search#​2, started 0.09s after GET /api/search#​1, had written (2 items ["re one", "re two"] → 2 items ["r one", "r two"]).

search.spec.ts > search > buggy page: results of the last query

5 seeds (1, 2, 3, 4, 5) · 1 signature · chaos: latency 0–600 ms, reorder

Witnesses (facts measured without the model)

  • Reproducible: 5 of 5 seeds (1, 2, 3, 4, 5) · GET /api/search · witness:overwrote-newer

    The response of GET /api/search#​1 wrote search.results over what newer GET /api/search#​4, started 0.25s after GET /api/search#​1, had written (2 items ["reac one", "reac two"] → 2 items ["r one", "r two"]).

3 tests with nothing flagged
  • [chromium] search.spec.ts > search > fixed page: results of the last query (2 seeds: 1, 2)
  • search.spec.ts > search > fixed page: results of the last query (5 seeds: 1, 2, 3, 4, 5)
  • search.spec.ts > search > latency only > buggy page, latency only: results of the last query (5 seeds: 1, 2, 3, 4, 5)

Lines under "Witnesses (facts measured without the model)" are happens-before facts the runtime measured in the page without the model, one per signature (witness kind, operation): overwrote-newer, a response wrote a field over what a newer request or the user had written since the request started; identical-in-flight, two identical requests in flight together from separate user actions. They carry no confidence: a fact is listed when it happened. Reproducible: seen in 2 or more seeds of the same test. Whether a fact is a bug is for you to decide (some overwrites are intended; many are repaired a moment later).


genclass-dev[bot] read 19 race files from the artifacts genclass-races-unmodified, genclass-races of this pull request's workflow run, never your source code. What the lines mean · Setup and settings · reply @genclass-dev help

@MeharPro
MeharPro merged commit 93eee19 into main Nov 17, 2026
16 of 17 checks passed
@MeharPro
MeharPro deleted the chore/private-prices branch November 17, 2026 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant