Skip to content

feat(coroutine): native federated OAuth start and opt-in callback/session path - #54

Open
thecompez wants to merge 43 commits into
perf/openproof-full-optimization-20261026from
feat/coroutine-federated-start-20261119
Open

thecompez wants to merge 43 commits into
perf/openproof-full-optimization-20261026from
feat/coroutine-federated-start-20261119

Conversation

@thecompez

@thecompez thecompez commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Scope (feature branch targeting Coroutine migration)

  • Native OAuth2 GET federation start/callback with AuthenticationService::beginAsync/completeAsync, PostgreSQL-backed native transaction finalizer and CoroutineReplacingSessionIssuer for atomic browser session issue/replacement.
  • Exact-path native overlay with strict opt-ins; start and callback must both be enabled, preventing a native/legacy transaction-store split. No silent fallback for unsupported SAML/POST, OAuth1 or account-connection callbacks.
  • Scrub owned raw callback query, authorization/body/cookie bytes before network/provider coroutines; bound one-time state, challenge, replay rejection, secure session cookies; dedicated C++ HTTP loopback tests.
  • Restore the disposable Farcaster local HTTPS RPC E2E fixture without relaxing default SSRF defenses: only OPENPROOF_FARCASTER_TRUSTED_LOOPBACK_RPC=1 with a literal https://127.0.0.1:<port>/ and a separately configured CA file permits loopback for the Farcaster RPC. Domain names and other private IP addresses remain forbidden; wallet and other HTTP clients remain public-only.
  • Security regressions for default-denied trusted-local RPC, invalid destinations and absent CA. Configuration documentation and isolation commentary.

Current evidence (20 November 2026)

  • Local GCC 16.2, isolated worktree at e9ecc8353c0df899db18a50911df582b85b46af9: successfully built and linked openproof_account_coroutine_http_tests, openproof_enterprise_coroutine_http_tests, and openproof_authentication_coroutine_tests. Ran ctest -R '^(NativeAccountSession|NativeEnterpriseLdapHttp|TrustedAsyncAuth)' --output-on-failure --parallel 1: 30/30 PASS, including real TCP Federated Start→Callback→Session tests, replay rejection and fail-closed tests. Ran seven focused concurrency/federation tests with ctest --repeat until-fail:30: 210/210 successful executions; ran both auth contract/security JS suites: 11/11 PASS and checked E2E JavaScript syntax. git diff --check and python3 scripts/check-protocol-neutrality.py pass.
  • CI #202 compiled its C++ target set but failed linking the standalone native Account HTTP test due to missing Boost.JSON implementation; added precisely one src/account/http/boost_json.cpp translation unit to that test target in e9ecc83. The local focused build and 30 tests above confirm that linker fix. CI #203 is pending, and full CI CTest has not yet passed.
  • Earlier CI runs #198–#202 built the opp executable and passed the disposable PostgreSQL/Farcaster HTTPS fixture E2E; however, this does not demonstrate native federated callback + real-provider + PostgreSQL E2E, since the native flags are disabled by default. Full end-to-end release acceptance remains outstanding.
  • Strict coroutine coverage Gate still NOT_APPROVED: 17 blocking findings in 11/25 areas (14/25 passing = 56% Gate area coverage, not project completion). Complete benchmark comparison, LDAP/provider integration and full release checklist remain open.
  • Only the feature branch was pushed. PR targets dev/perf; neither main nor production was changed. No production deployment or release approval is permitted based on these tests.

@thecompez thecompez changed the title feat(coroutine): native federated OAuth start path with explicit opt-in feat(coroutine): native federated OAuth start and opt-in callback/session path Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant