Repository navigation
fix: handled CRLF line endings in commit subject validation - #64
Merged
Merged
Conversation
Commits created through GitHub web forms (e.g. commit or "Apply suggestion" dialogs) or Windows editors can have CRLF line endings. Splitting the message on "\n" only left a trailing "\r" on the subject, which the title pattern could not match, so valid commits failed the PR content check. The commit message is now split on /\r?\n/, so the extracted subject no longer carries the carriage return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits created through GitHub web forms (e.g. commit or "Apply suggestion" dialogs) or Windows editors can have CRLF line endings. Splitting the commit message on
\nonly left a trailing\ron the subject. The title pattern couldn't match it, so valid commits failed the commit message validation.The commit message is now split on
/\r?\n/, so the subject no longer carries the carriage return.Port of swissgeo/.github#27.