Skip to content

fix(warden): Run Warden when a draft PR is marked ready - #226

Closed
sentry-junior[bot] wants to merge 1 commit into
mainfrom
warden/run-on-ready-for-review
Closed

sentry-junior[bot] wants to merge 1 commit into
mainfrom
warden/run-on-ready-for-review

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

Adds ready_for_review to the org Warden workflow's pull_request types.

Repo configs are starting to set draft = false on their skill triggers so Warden skips draft PRs and saves tokens. Right now the workflow never fires on ready_for_review, so a PR opened as a draft gets no review from those skills when it's marked ready, only on its next push.

The org security-review skill in warden.toml is unchanged. Its triggers don't list ready_for_review, so for repos without their own config this event starts the job but matches no skill. Warden supports ready_for_review as a trigger action (PullRequestActionSchema in packages/warden/src/types/index.ts).

These PRs use it:

via amir.

--

View Session [Sentry]

Co-Authored-By: Amir Mujacic <amir.mujacic@sentry.io>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b352523. Configure here.

on:
pull_request:
types: [opened, synchronize, reopened]
types: [opened, synchronize, reopened, ready_for_review]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready-for-review trigger is ignored

High Severity

GitHub ruleset-required workflows ignore types filters and only run on opened, synchronize, and reopened. This org workflow is enforced that way on other repos, so adding ready_for_review never starts a run. Skills with draft = false still skip drafts and only review on a later push.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit b352523. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant