Repository navigation
fix(warden): Run Warden when a draft PR is marked ready - #226
Closed
sentry-junior[bot] wants to merge 1 commit into
Closed
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Amir Mujacic <amir.mujacic@sentry.io>
This was referenced Nov 11, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b352523. Configure here.
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
| types: [opened, synchronize, reopened, ready_for_review] |
There was a problem hiding this comment.
Ready-for-review trigger is ignored
High Severity
GitHub ruleset-required workflows ignore types filters and only run on opened, synchronize, and reopened. This org workflow is enforced that way on other repos, so adding ready_for_review never starts a run. Skills with draft = false still skip drafts and only review on a later push.
Reviewed by Cursor Bugbot for commit b352523. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds
ready_for_reviewto the org Warden workflow'spull_requesttypes.Repo configs are starting to set
draft = falseon their skill triggers so Warden skips draft PRs and saves tokens. Right now the workflow never fires onready_for_review, so a PR opened as a draft gets no review from those skills when it's marked ready, only on its next push.The org
security-reviewskill inwarden.tomlis unchanged. Its triggers don't listready_for_review, so for repos without their own config this event starts the job but matches no skill. Warden supportsready_for_reviewas a trigger action (PullRequestActionSchemainpackages/warden/src/types/index.ts).These PRs use it:
via amir.
--
View Session [Sentry]