Skip to content

ci(warden): Skip per-version Bundler lockfiles - #227

Open
sentry-junior[bot] wants to merge 2 commits into
mainfrom
warden/ignore-gemfile-lockfiles
Open

sentry-junior[bot] wants to merge 2 commits into
mainfrom
warden/ignore-gemfile-lockfiles

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

This adds **/*.gemfile.lock to the org [defaults] ignorePaths.

sentry-ruby keeps one Bundler lockfile per Ruby and Rails combination, for example sentry-rails/gemfiles/ruby-3.3_rails-7.2.0.gemfile.lock. Warden's built-in skip list only covers Gemfile.lock, so the org security-review skill reads every one of these files.

From the Warden job logs for Nov 11–13:

  • security-review reviewed these lockfiles 108 times, for about $20.60. That's about 28% of all Warden spend across sentry-python, sentry-go, sentry-ruby and sentry-dotnet.
  • One lockfile cost $3.10.
  • Two lockfile reviews each held a job for 49–54 min.

A lockfile-only diff rarely gives security-review anything to report, because the skill doesn't report generic dependency CVEs. The Gemfiles and *.gemspecs stay reviewed.

Two side effects:

  • This changes the effective config of org-defined skills. The next push on each open PR will review the full PR once with security-review, the same as after a Warden release.
  • Repo-level skills are unaffected, because org ignorePaths don't apply to them.

I checked the pattern against Warden's glob matcher: it matches sentry-rails/gemfiles/*.gemfile.lock and sentry-ruby/gemfiles/*.gemfile.lock, and doesn't match Gemfile, *.gemspec or *.gemfile.

Part of SDK-1579.

via @dingsdax.

--

View Session [Sentry]

Warden's built-in skip covers Gemfile.lock but not Appraisal-style
gemfiles/*.gemfile.lock, so security-review read every one of them.

Co-Authored-By: johdax <114897+dingsdax@users.noreply.github.com>
@sentry-junior
sentry-junior Bot requested a review from a team as a code owner November 13, 2026 09:37
@sentry-junior
sentry-junior Bot requested a review from dingsdax November 13, 2026 09:37
@linear-code

linear-code Bot commented Nov 13, 2026

Copy link
Copy Markdown

SDK-1579

Co-Authored-By: johdax <114897+dingsdax@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants