Repository navigation
ci(warden): Skip per-version Bundler lockfiles - #227
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Warden's built-in skip covers Gemfile.lock but not Appraisal-style gemfiles/*.gemfile.lock, so security-review read every one of them. Co-Authored-By: johdax <114897+dingsdax@users.noreply.github.com>
Co-Authored-By: johdax <114897+dingsdax@users.noreply.github.com>
dingsdax
approved these changes
Nov 13, 2026
solnic
approved these changes
Nov 13, 2026
Jeffreyhung
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
**/*.gemfile.lockto the org[defaults] ignorePaths.sentry-ruby keeps one Bundler lockfile per Ruby and Rails combination, for example
sentry-rails/gemfiles/ruby-3.3_rails-7.2.0.gemfile.lock. Warden's built-in skip list only coversGemfile.lock, so the orgsecurity-reviewskill reads every one of these files.From the Warden job logs for Nov 11–13:
security-reviewreviewed these lockfiles 108 times, for about $20.60. That's about 28% of all Warden spend across sentry-python, sentry-go, sentry-ruby and sentry-dotnet.A lockfile-only diff rarely gives
security-reviewanything to report, because the skill doesn't report generic dependency CVEs. TheGemfiles and*.gemspecs stay reviewed.Two side effects:
security-review, the same as after a Warden release.ignorePathsdon't apply to them.I checked the pattern against Warden's glob matcher: it matches
sentry-rails/gemfiles/*.gemfile.lockandsentry-ruby/gemfiles/*.gemfile.lock, and doesn't matchGemfile,*.gemspecor*.gemfile.Part of SDK-1579.
via @dingsdax.
--
View Session [Sentry]