Skip to content

fix(secret-scan): check event head SHA - #228

Merged
geoffg-sentry merged 1 commit into
mainfrom
geoffg-sentry/secret-scan-moving-ref
Nov 16, 2026
Merged

geoffg-sentry merged 1 commit into
mainfrom
geoffg-sentry/secret-scan-moving-ref

Conversation

@geoffg-sentry

@geoffg-sentry geoffg-sentry commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Some updates to #220 for scanning diffs in place:

  • Check out the event head SHA instead of refs/pull/N/head or the merge queue branch, so force-pushes and dequeued entries can't change what gets scanned
  • Move the history deepen into its own step, fetching only the head commit rather than all branches
  • Fail the job on history setup errors instead of reporting them as secret findings to SIEM

Some updates to #220 for scanning diffs in place:
- Check out the event head SHA instead of refs/pull/N/head or the merge queue branch, so force-pushes and dequeued entries can't change what gets scanned.
- Move the history deepen into its own step, fetching only the head commit rather than all branches.
- Fail the job on history setup errors instead of reporting them as secret findings to the SIEM.
@geoffg-sentry
geoffg-sentry requested a review from a team as a code owner November 13, 2026 16:37
@geoffg-sentry
geoffg-sentry merged commit be31098 into main Nov 16, 2026
9 checks passed
@geoffg-sentry
geoffg-sentry deleted the geoffg-sentry/secret-scan-moving-ref branch November 16, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants