Repository navigation
Trigger warden when PR moved to ready for review - #230
geoffg-sentry wants to merge 1 commit into
Conversation
Problem we have today is that warden cannot trigger when a PR is moved from draft to ready_for_review because our warden usage uses rulesets. Rulesets can't be used to track that state change. This should mean we catch the state change and this new workflow should not trigger when a PR is cut directly as ready since there's no state change.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 928684c. Configure here.
| jobs: | ||
| warden: | ||
| if: github.event.pull_request.head.repo.full_name == github.repository | ||
| uses: getsentry/.github/.github/workflows/warden.yml@main |
There was a problem hiding this comment.
Called workflow is not reusable
High Severity
The warden job calls warden.yml via uses, which GitHub only accepts for reusable workflows. warden.yml has no workflow_call trigger, so the run fails as soon as a PR is marked ready for review and Warden never starts.
Reviewed by Cursor Bugbot for commit 928684c. Configure here.
| name: Warden - PR Ready for Review | ||
| on: | ||
| pull_request: | ||
| types: [ready_for_review] |
There was a problem hiding this comment.
Skill triggers omit ready_for_review
High Severity
This workflow runs on ready_for_review, but the org security-review skill in warden.toml only triggers on opened, synchronize, and reopened. Warden matches GitHub Actions runs on event and action, so that skill is skipped and converting a draft PR to ready still produces no review.
Reviewed by Cursor Bugbot for commit 928684c. Configure here.


Problem we have today is that warden cannot trigger when a PR is moved from draft to ready_for_review because our warden usage uses rulesets. Rulesets can't be used to track that state change.
This should mean we catch the state change and this new workflow should not trigger when a PR is cut directly as ready since there's no state change.