fix(issue): Handle object headers in buildRequestMarkdown - #1441
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
buildRequestMarkdownfunction insrc/lib/formatters/human.tsexpecteddata.headersto be an iterable array of[key, value]tuples. However, the Sentry API can return headers as a plainRecord<string, string>object, leading to aTypeError: .for is not iterablewhen attempting to iterate over it.This fix addresses the issue by:
headerstype inRequestEntry(src/types/sentry.ts) to includeRecord<string, string>as a possible shape, aligning with the actual API response.data.headersto an iterable array usingArray.isArray(data.headers) ? data.headers : Object.entries(data.headers)before iterating inbuildRequestMarkdown. This ensures thefor...ofloop always receives an iterable, preventing the TypeError.Fixes CLI-297
This PR was automatically generated by Sentry. You can adjust this setting at any time.