fix(pii): Prevent cycles in rule collection - #6344
Merged
Merged
Conversation
jjbayer
marked this pull request as ready for review
September 2, 2026 10:15
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
loewenheim
approved these changes
Sep 2, 2026
jjbayer
enabled auto-merge
September 2, 2026 13:32
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
jjbayer
disabled auto-merge
September 2, 2026 13:49
Dav1dde
approved these changes
Sep 2, 2026
| } else { | ||
| None | ||
| }; | ||
| rules.insert(rule.clone()); // insert to break cycles |
Member
There was a problem hiding this comment.
Would it be possible to insert before the match and remove with a drop impl?
Contributor
There was a problem hiding this comment.
See mstange/pdb-addr2line#71 for some prior art for this, though it might be overkill.
Member
Author
There was a problem hiding this comment.
I ended up simplifying the entire implementation by adding a second set which keeps track of all seen nodes.
jjbayer
enabled auto-merge
September 7, 2026 08:21
loewenheim
approved these changes
Sep 7, 2026
jjbayer
disabled auto-merge
September 7, 2026 08:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When collecting rules from a PII config, temporarily insert non-leaf nodes into the set of seen nodes to prevent cycles.
Fixes INGEST-1127