Repository navigation
ci(release): Bump craft to 3.9.0 and update config - #3495
Merged
Merged
Conversation
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
BYK
approved these changes
Nov 4, 2026
BYK
enabled auto-merge (rebase)
November 4, 2026 00:05
dingsdax
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the release workflow's pinned
getsentry/craftaction from 3.4.0 (4a8dba2a) to 3.9.0 (2e29b081) and updates.craft.ymlto match. It supersedes the Dependabot bump to 3.5.0 in #3494, which doesn't include the fix below.Why: craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so later steps kept going and could open a getsentry/publish issue even with a
release-blockerissue open (seen in getsentry/symbolic run 41665569364). getsentry/craft#956 fixed this in 3.9.0.Action inputs only gained new optional ones between 3.4.0 and 3.9.0, so the existing
with:inputs stay valid.Config changes (
.craft.yml):minVersionto 3.9.0 (was 0.23.1).changelogPolicy: autowithchangelog.policy: auto.versioning.policy: manual. BelowminVersion2.14.0, craft defaulted to manual versioning, and at 3.9.0 the default would becomeauto. This keeps it manual.preReleaseCommand: bash scripts/bump-version.sh. BelowminVersion2.21.0, craft ran that script by default. From 2.21.0 on, it switches to automatic target bumping instead, so without this line the script would stop running.craft 3.9.0
prepare 99.0.0 --dry-run --no-push, run before and after the config change, bumps the same 13 files (CHANGELOG.md, Cargo.toml/Cargo.lock, package.json/package-lock.json and the npm-binary-distributions packages) with no new errors or warnings, and thechangelogPolicydeprecation warning is gone.There are no open
release-blockerissues here right now. Once this lands, an open one will stop releases until it's closed orforceis set.via @BYK.
--
View Session in Sentry