Skip to content

add apollo5 docs to android and java - #19558

Merged
dingsdax merged 6 commits into
masterfrom
lbloder/apollo5
Nov 5, 2026
Merged

dingsdax merged 6 commits into
masterfrom
lbloder/apollo5

Conversation

@lbloder

@lbloder lbloder commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

DESCRIBE YOUR PR

Docs for the apollo5 integration implemented in getsentry/sentry-java#6074

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace YYYY-MM-DD with the due date. You can update this information later by editing the PR description.

  • Urgent deadline (GA date, etc.): YYYY-MM-DD
  • Other deadline: YYYY-MM-DD
  • No deadline: Not urgent, can wait up to 1 week+

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
develop-docs Ready Ready Preview Nov 5, 2026 1:57pm UTC
sentry-docs Ready Ready Preview Nov 5, 2026 1:57pm UTC

Request Review

@github-actions github-actions Bot added the Priority: Needs Triage The PR description is missing valid priority information label Sep 22, 2026
@codeowner-assignment
codeowner-assignment Bot requested review from a team September 22, 2026 13:56

@adinauer adinauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just one comment

ApolloClient apollo = SentryApolloBuilderExtensionsKt.sentryTracing(
new ApolloClient.Builder(),
true,
Collections.singletonList(SentryOptions.DEFAULT_PROPAGATION_TARGETS),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: DEFAULT_PROPAGATION_TARGETS is marked internal. We could just provide a custom list as sample here or hard code the .* value. Or we open up the default constant.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, i think i'll remove it. Since we don't show that parameter in the apollo-4 docs or in the kotlin version of this one. WDYT?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, that is an issue in the apollo-4 docs. have a list of issues with the apollo3 and 4 docs, that get their own issue and pr. Went with ".*"

@codeowner-assignment
codeowner-assignment Bot requested a review from a team October 2, 2026 09:28
@lbloder
lbloder marked this pull request as ready for review October 5, 2026 08:57
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Please update the IS YOUR CHANGE URGENT? section of the PR description:

  • Select exactly one option.
  • If you selected an urgent or other deadline, provide the date as YYYY-MM-DD.

This information helps the Docs team prioritize your review.

@codeowner-assignment
codeowner-assignment Bot requested a review from a team October 5, 2026 08:58
@cursor

cursor Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Services awaiting deployment · Rollout details

Warning

Rollouts can't watch this change after it deploys: every data source for this team needs to be signed in again, so a check has no telemetry to read. Sign in to your data sources, or ask a team admin to.

Status Service Environment
⚪ Not deployed yet sentry-docs

Mention @rollout in a comment to update the plan.


<Alert>

To capture transactions, first <PlatformLink to="/tracing/">set up tracing</PlatformLink>.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still using the term "transactions" for this type of data?


<Alert>

To capture transactions, first <PlatformLink to="/tracing/">set up tracing</PlatformLink>.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question about transactions

@sfanahata sfanahata left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a formatting and general content perspective. Will leave to the experts on when it's ready to merge and accuracy.

@codeowner-assignment
codeowner-assignment Bot requested review from a team, markushi and runningcode and removed request for a team November 4, 2026 10:25
@codeowner-assignment
codeowner-assignment Bot requested a review from a team November 5, 2026 13:51
@dingsdax
dingsdax merged commit be4138f into master Nov 5, 2026
29 checks passed
@dingsdax
dingsdax deleted the lbloder/apollo5 branch November 5, 2026 14:00

This branch was successfully deployed

2 active deployments
Preview – sentry-docs — 8b6d0ae8 Deployed Nov 5, 2026 by vercel[bot]
Preview – develop-docs — 8b6d0ae8 Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Needs Triage The PR description is missing valid priority information

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants