Skip to content

ci: Watch the new upstream AssemblyStore reader path - #5900

Merged
jamescrosswell merged 2 commits into
mainfrom
ci/watch-upstream-assembly-store-path
Nov 11, 2026
Merged

jamescrosswell merged 2 commits into
mainfrom
ci/watch-upstream-assembly-store-path

Conversation

@jamescrosswell

@jamescrosswell jamescrosswell commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

dotnet/android#13380 moved the AssemblyStore reader from .github/skills/read-assembly-store/src/AssemblyStore to tests/Utilities/AssemblyStore. The old path will never get another commit, so watch-upstream.sh finds its latest commit already tracked and skips every run.

This points the watcher at the new location. The old comment recording the previous move was stale, so it's gone.

The upstream commit also removed LZ4 decoding from upstream's reader. We keep it, because apps built with .NET 9 and .NET 10 still ship LZ4-compressed assemblies, so this adds a one-line comment to ArchiveUtils.cs saying so.

The duplicate check includes the path, so the first run after merge opens one more alert for 3c492f0. That one can be closed without review.

Closes #5898

#skip-changelog

🤖 Generated with Claude Code

dotnet/android#13380 moved the reader to tests/Utilities/AssemblyStore. The old path no longer changes, so the watcher would skip every run and never alert again.

Refs #5898

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.87%. Comparing base (2b68abe) to head (d0c52dd).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5900      +/-   ##
==========================================
+ Coverage   76.77%   76.87%   +0.10%     
==========================================
  Files         532      533       +1     
  Lines       19826    19847      +21     
  Branches     3909     3920      +11     
==========================================
+ Hits        15222    15258      +36     
+ Misses       3718     3709       -9     
+ Partials      886      880       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell
jamescrosswell marked this pull request as ready for review November 9, 2026 20:18
@github-actions github-actions Bot added the risk: low PR risk score: low label Nov 9, 2026

@ric-oliv ric-oliv left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3c492f0 isn't only a move. AssemblyCompression.cs drops LZ4 decoding and now throws NotSupportedException for XALZ payloads. K4os.Compression.LZ4 is also gone from the repo. There's nothing to port for us, since net9 and net10 apps still ship LZ4.
Could we leave the usual "reviewed, nothing to port" note on #5898 before this PR closes it?

It might be worth a line on #5346 too. The triage there says LZ4 can't be dropped, and upstream has now dropped it from its reader.

Upstream dropped LZ4 from .NET 11 builds (dotnet/android#11730) and from its own reader (dotnet/android#13380), but apps built with .NET 9 and .NET 10 still ship LZ4-compressed assemblies.

Refs #5898

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: low PR risk score: low labels Nov 11, 2026
@jamescrosswell
jamescrosswell merged commit aebbeb2 into main Nov 11, 2026
59 checks passed
@jamescrosswell
jamescrosswell deleted the ci/watch-upstream-assembly-store-path branch November 11, 2026 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upstream change detected: dotnet/android .github/skills/read-assembly-store/src/AssemblyStore @ 3c492f0

2 participants