Skip to content

ci(warden): Run code-review and sdk-review on ready_for_review - #5942

Closed
sentry-junior[bot] wants to merge 1 commit into
mainfrom
ci/warden-ready-for-review
Closed

sentry-junior[bot] wants to merge 1 commit into
mainfrom
ci/warden-ready-for-review

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

code-review and sdk-review are gated on draft = false, but they only trigger on opened, synchronize, and reopened. When a draft is marked ready without a new push, which is our normal process, neither skill runs. That's what happened on #5930 and #5932.

This adds ready_for_review to both triggers. It does nothing until getsentry/.github#229 is merged, because the org Warden workflow doesn't fire on that event yet.

The label-gated gha-security-review and security-review triggers are left as they are.

#skip-changelog

via Ricardo Oliveira.

--

View Session [Sentry]

Co-Authored-By: Ricardo Oliveira <ricardo.oliveira@sentry.io>
@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.44%. Comparing base (b9a48d2) to head (dce2ec9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5942   +/-   ##
=======================================
  Coverage   77.43%   77.44%           
=======================================
  Files         546      546           
  Lines       20053    20053           
  Branches     3962     3962           
=======================================
+ Hits        15529    15531    +2     
+ Misses       3659     3658    -1     
+ Partials      865      864    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sentry-junior
sentry-junior Bot marked this pull request as ready for review November 16, 2026 11:27
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 16, 2026
@sentry-junior

sentry-junior Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of #5944. The org Warden workflow never runs on ready_for_review (ruleset-required workflows ignore types), so this trigger would never match.

@sentry-junior sentry-junior Bot closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants