Repository navigation
ci(warden): Run code-review and sdk-review on ready_for_review - #5942
Closed
sentry-junior[bot] wants to merge 1 commit into
Closed
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Ricardo Oliveira <ricardo.oliveira@sentry.io>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5942 +/- ##
=======================================
Coverage 77.43% 77.44%
=======================================
Files 546 546
Lines 20053 20053
Branches 3962 3962
=======================================
+ Hits 15529 15531 +2
+ Misses 3659 3658 -1
+ Partials 865 864 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sentry-junior
Bot
requested review from
jamescrosswell and
ric-oliv
as code owners
November 16, 2026 11:27
Contributor
Author
|
Closing in favor of #5944. The org Warden workflow never runs on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code-reviewandsdk-revieware gated ondraft = false, but they only trigger onopened,synchronize, andreopened. When a draft is marked ready without a new push, which is our normal process, neither skill runs. That's what happened on #5930 and #5932.This adds
ready_for_reviewto both triggers. It does nothing until getsentry/.github#229 is merged, because the org Warden workflow doesn't fire on that event yet.The label-gated
gha-security-reviewandsecurity-reviewtriggers are left as they are.#skip-changelog
via Ricardo Oliveira.
--
View Session [Sentry]