Skip to content

Add opt-in strict callback mode #6662

Open

Description

@sentry-junior

The SDK isolates failures in user callbacks (beforeSend*, beforeBreadcrumb, samplers, event processors, etc.): the error is logged, the data is dropped, and a callback_error client report is recorded (#6081, released in 8.61.0). There is currently no way to make those failures surface, which makes buggy callbacks hard to notice and debug during development.

The callback error isolation spec (getsentry/sentry-docs#19189) allows an opt-in strict mode:

  • MAY offer it, disabled by default.
  • In strict mode, a callback failure MUST propagate as an unhandled error of the host application instead of being isolated.
  • The event reporting that error MUST NOT go through the callback that failed.
  • Any callback failure while processing that event, or data created while reporting it (e.g. breadcrumbs), MUST be isolated instead of propagated.

Outside strict mode, the SDK MUST NOT re-throw or capture callback errors as events.

Prior attempt

A draft implementation was closed unmerged as not ready: #6173 (branch feat/strict-callback-mode, built on the callback-errors stack starting at #6140). It added a strictCallbackMode option (default off) with:

  • Callback failures wrapped in marker exceptions/errors with the original failure as cause, propagated via ExceptionUtils.maybeRethrow() before logging or discard accounting, including enclosing SDK catches and async completion paths.
  • Events containing a callback marker (incl. nested/cyclic causes and ExceptionMechanismException) silently excluded before capture callbacks, processors, logging, or discard accounting; same exclusion in the JUL, Logback, Log4j2, and Timber integrations.
  • Async failures following the host API's behavior (returned futures keep the failure; the SDK does not terminate the process).
  • Config via SDK options, strict-callback-mode external config, io.sentry.strict-callback-mode Android manifest metadata, and sentry.strict-callback-mode Spring Boot property.

Open points from review on #6173:

  • Design of CallbackUtils.
  • Some code paths started throwing where they previously swallowed exceptions independent of the flag, which would be a breaking change for a minor.
  • Marker logging during uncaught-exception capture, feedback dismiss-listener cleanup, and proxy-only Log4j2 events.

Related: #5513 (stop catching non-recoverable Throwables in the next major) is a separate, broader change.

Shipping behind the flag in a minor and possibly flipping the default in a major was floated as an option.

via alexander.dinauer.

--

View Session [Sentry]

Activity

  1. linear-code commented on Nov 18, 2026

    @linear-code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions