-
-
Notifications
You must be signed in to change notification settings - Fork 475
feat(replay): Add manual replay control API #5978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
romtsn
wants to merge
5
commits into
romtsn/feat/java-665-replay-start-stop
Choose a base branch
from
romtsn/feat/java-325-replay-control-api
base: romtsn/feat/java-665-replay-start-stop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a05b31d
feat(replay): Add manual replay control API
romtsn 05bdcbc
changelog
romtsn bd1914c
fix(replay): Ignore foreground before registration
romtsn 8073208
fix(replay): Bypass sampling for manual buffers
romtsn 0582fec
revert: fix(replay): Bypass sampling for manual buffers
romtsn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -141,14 +141,6 @@ public class ReplayIntegration( | |
| return | ||
| } | ||
|
|
||
| if ( | ||
| !options.sessionReplay.isSessionReplayEnabled && | ||
| !options.sessionReplay.isSessionReplayForErrorsEnabled | ||
| ) { | ||
| options.logger.log(INFO, "Session replay is disabled, no sample rate specified") | ||
| return | ||
| } | ||
|
|
||
| this.scopes = scopes | ||
| recorder = | ||
| recorderProvider?.invoke() | ||
|
|
@@ -167,10 +159,38 @@ public class ReplayIntegration( | |
| override fun isRecording(): Boolean = state.get().isRecording | ||
|
|
||
| override fun start() { | ||
| enqueueOnMainThread { startInternal() } | ||
| enqueueOnMainThread { startInternal(isFullSession = true) } | ||
| } | ||
|
|
||
| private fun startInternal() { | ||
| override fun startBuffering() { | ||
| enqueueOnMainThread { startInternal(isFullSession = false) } | ||
| } | ||
|
|
||
| override fun onAppForegrounded(startNewSession: Boolean) { | ||
| enqueueOnMainThread { | ||
| if (!isEnabled.get()) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would it make more sense to check this condition before enqueing? |
||
| return@enqueueOnMainThread | ||
| } | ||
| if (startNewSession) { | ||
| val isFullSession = sample(options.sessionReplay.sessionSampleRate) | ||
| if (!isFullSession && !options.sessionReplay.isSessionReplayForErrorsEnabled) { | ||
| options.logger.log( | ||
| INFO, | ||
| "Session replay is not started, full session was not sampled and onErrorSampleRate is not specified", | ||
| ) | ||
| } else { | ||
| startInternal(isFullSession) | ||
| } | ||
| } | ||
| resumeInternal() | ||
| } | ||
| } | ||
|
|
||
| override fun onAppBackgrounded() { | ||
| enqueueOnMainThread { pauseInternal() } | ||
| } | ||
|
|
||
| private fun startInternal(isFullSession: Boolean) { | ||
| if (!isEnabled.get()) { | ||
| return | ||
| } | ||
|
|
@@ -184,15 +204,7 @@ public class ReplayIntegration( | |
| return | ||
| } | ||
|
|
||
| val isFullSession = sample(options.sessionReplay.sessionSampleRate) | ||
| if (!isFullSession && !options.sessionReplay.isSessionReplayForErrorsEnabled) { | ||
| options.logger.log( | ||
| INFO, | ||
| "Session replay is not started, full session was not sampled and onErrorSampleRate is not specified", | ||
| ) | ||
| return | ||
| } | ||
|
|
||
| isManualPause = false | ||
| val strategy = | ||
| replayCaptureStrategyProvider?.invoke(isFullSession) | ||
| ?: if (isFullSession) { | ||
|
|
@@ -334,6 +346,17 @@ public class ReplayIntegration( | |
|
|
||
| override fun getReplayId(): SentryId = state.get().replayId | ||
|
|
||
| override fun flush() { | ||
|
cursor[bot] marked this conversation as resolved.
|
||
| enqueueOnMainThread { | ||
| val current = state.get() | ||
| if (!current.isRecording) { | ||
| startInternal(isFullSession = true) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why does |
||
| } else { | ||
| captureReplayInternal(current.generation, current.replayId, false) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| override fun setBreadcrumbConverter(converter: ReplayBreadcrumbConverter) { | ||
| replayBreadcrumbConverter = converter | ||
| } | ||
|
|
@@ -399,6 +422,7 @@ public class ReplayIntegration( | |
| recorder?.stop() | ||
| gestureRecorder?.stop() | ||
| current.captureStrategy?.stop() | ||
| isManualPause = false | ||
| state.set( | ||
| current.copy( | ||
| lifecycleState = STOPPED, | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make more sense to check this condition before enqueing?