Repository navigation
Conversation
Contributor
|
This was referenced Nov 11, 2026
📲 Install BuildsAndroid
|
adinauer
marked this pull request as ready for review
November 12, 2026 09:04
adinauer
requested review from
0xadam-brown and
romtsn
and removed request for
a team
November 12, 2026 09:04
runningcode
reviewed
Nov 16, 2026
|
|
||
| private @Nullable List<HttpStatusCodeRange> ignoredServerHttpStatusCodesForTracing = null; | ||
| private @Nullable List<HttpStatusCodeRange> ignoredServerHttpStatusCodesForTracing = | ||
| new ArrayList<>(Collections.singletonList(new HttpStatusCodeRange(404))); |
Contributor
There was a problem hiding this comment.
The spec has a list of recommendations. Is there a reason we differ from the spec? https://develop.sentry.dev/sdk/telemetry/traces/
Separately, (as mentioned on a previous PR) this exposes a mutable list. Is that okay in this context?
Stop sending incoming server transactions that finish with HTTP 404 unless users replace or clear the ignored status configuration. Document the opt-out and cover native Spring and OpenTelemetry paths across supported Spring Boot generations. Fixes #4736
# Conflicts: # sentry-spring-boot-4/src/test/kotlin/io/sentry/spring/boot4/SentryAutoConfigurationTest.kt # sentry-spring-boot-jakarta/src/test/kotlin/io/sentry/spring/boot/jakarta/SentryAutoConfigurationTest.kt # sentry-spring-boot/src/test/kotlin/io/sentry/spring/boot/SentryAutoConfigurationTest.kt
adinauer
force-pushed
the
feat/ignore404-filter
branch
from
November 17, 2026 08:13
629bf40 to
8eb7843
Compare
adinauer
force-pushed
the
feat/ignore404-default
branch
from
November 17, 2026 08:13
a76505b to
0a7d341
Compare
Default traceIgnoreStatusCodes to 301-303, 305-399, and 401-404 instead of only 404. Update documentation and boundary coverage so excluded gaps remain captured. Refs #4736 Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (Ignore HTTP Status)
📜 Description
Default
traceIgnoreStatusCodesto the specification-recommended ranges301-303,305-399, and401-404. Completed incoming server transactions with matching statuses are therefore no longer sent to Sentry unless users replace or clear the configuration.Explicit custom lists still replace the default, while an empty list or empty external/Spring configuration restores tracing for every incoming HTTP status. The Spring Boot documentation and breaking-change entry include Java, properties, and YAML opt-out examples.
💡 Motivation and Context
Redirects and selected client-error transactions are commonly low-value tracing noise. This aligns the default requested in #4736 with the specification while retaining the narrow filtering rules from the previous stack PR: only root server transactions with a numeric root response status are affected. Outgoing HTTP requests, errors, logs, metrics, replay, continuous profile chunks, and external OTLP export remain independent.
Fixes #4736
💚 How did you test it?
SentryOptionsTestandSentryClientTest, including boundaries and excluded gaps for301-303,305-399, and401-404make format apigit diff --check📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Coordinate the corresponding migration/options documentation in
sentry-docsbefore the 9.x release.