Repository navigation
build(deps): Bump Shadow to 9.6.1 - #6617
Open
runningcode wants to merge 1 commit into
Open
runningcode wants to merge 1 commit into
runningcode wants to merge 1 commit into
Conversation
Shadow 9.6 marks DependencyFilter with a DSL marker. The agent's
dependencies { exclude("group:name") } calls had always resolved to the
outer ShadowJar.exclude(String) file pattern, so they never excluded
anything. They now fail to compile. javaagentLibs has none of those
artifacts, so drop the block.
Jar contents are unchanged. Shadow 9.5's KotlinModuleMetadataTransformer
reorders *.kotlin_module entries and drops their Unix mode, and the
shadowRuntimeElements variant now comes first in the .module file.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
runningcode
marked this pull request as ready for review
November 16, 2026 09:45
runningcode
requested review from
markushi and
romtsn
and removed request for
a team
November 16, 2026 09:45
📲 Install BuildsAndroid
|
runningcode
commented
Nov 16, 2026
| exclude("**/module-info.class") | ||
| relocatePackages(this) | ||
|
|
||
| // exclude known bootstrap dependencies - they can't appear in the inst/ directory |
Contributor
Author
There was a problem hiding this comment.
@adinauer do you know what you were trying to do here? they have no effect as this isn't an API on the shadowJar task.
Member
There was a problem hiding this comment.
IIRC i copied those from the sample otel had, i'll check
0xadam-brown
approved these changes
Nov 16, 2026
0xadam-brown
left a comment
Member
There was a problem hiding this comment.
Lgtm (but feel free to wait for @adinauer to respond if you care to, of course).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Bumps Shadow from 9.4.1 to 9.6.1 and removes the
dependencies { exclude(...) }block fromrelocateJavaagentLibsinsentry-opentelemetry-agent.That block never excluded anything.
DependencyFilterhas noexclude(String), so Kotlin resolved each call to the outerShadowJar.exclude(String), a file pattern that matches no file. Shadow 9.6.0 applies@ShadowDsltoDependencyFilter(GradleUp/shadow#2090), which turns those calls into a compile error. Rewriting them asexclude(dependency(...))would be a no-op too:javaagentLibsresolves only Sentry modules, and two of the listed coordinates no longer exist.The published artifacts keep their contents. Built the agent's
distZipand every sample shadow jar on main and on this branch, with--no-build-cache:*.kotlin_moduleentries differ: they move to the end of the archive and lose their Unix mode, because Shadow 9.5.0 now writes them through its newKotlinModuleMetadataTransformer..modulelistsshadowRuntimeElementsfirst instead of last, since Shadow 9.5.0 no longer adds variants inafterEvaluate. Apart from that and the jar hashes, it is identical.💡 Motivation and Context
Dependabot's #6607 makes the same bump, but every build there fails with the compile error above, and its branch is far behind main. This PR replaces it.
📝 Checklist
sendDefaultPIIis enabled.🤖 Generated with Claude Code
#skip-changelog