Skip to content

ref(skill): Defer to the shared Sentry skills in create-java-pr - #6621

Merged
runningcode merged 4 commits into
mainfrom
no/create-java-pr-use-pr-writer
Nov 17, 2026
Merged

runningcode merged 4 commits into
mainfrom
no/create-java-pr-use-pr-writer

Conversation

@runningcode

@runningcode runningcode commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

📜 Description

So this does 2 things

  1. the create-java-pr skill now refers to the pr-writer instead of the create-pr skill. getsentry/skills renamed create-pr to pr-writer (ref(skills): Promote pr-writer and skill-writer as canonical names skills#79) in March. So you'll need to update your getsentry/skills.
  2. remove duplicate, confusing instructions and simplify.

Here's a summary from my agent of the duplicates and simplification.

  • Step 1 invokes sentry-skills:create-branch, Step 3 relies on sentry-skills:commit for the message format, and Step 5 invokes sentry-skills:pr-writer for the title. The local copies of these rules are gone. They had already drifted: the allowed commit types were missing revert.
  • The repo PR template still sets the body structure, overriding pr-writer's default short body.
  • #skip-changelog now goes into the first PR body. Before, the PR was created first and its body was downloaded, edited and re-uploaded just to add that line.
  • PR bodies are written to per-branch or per-PR files instead of /tmp/pr-body.md.

💡 Motivation and Context

getsentry/skills renamed create-pr to pr-writer (getsentry/skills#79) and then removed the old name (getsentry/skills#110), so Step 5 called a skill that no longer exists.

/tmp/pr-body.md survives between sessions and is also the file pr-writer uses. If writing the new body failed, gh uploaded whatever an earlier session left there. That is how #6187 was opened with another PR's body, which GitHub then linked to issue #6175.

💚 How did you test it?

This PR was opened by following the updated Step 5, and this description was updated with the updated "Editing PR Descriptions" procedure.

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

None.

🤖 Generated with Claude Code

#skip-changelog

getsentry/skills renamed create-pr to pr-writer and then removed the old name, so Step 5
called a skill that no longer exists. Keep the repo PR template as the body structure
over pr-writer's default shape, as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sentry

sentry Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.64.0 (1) release

⚙️ sentry-android Build Distribution Settings

Branch naming, commit format, and PR title format now come from create-branch, commit, and
pr-writer instead of local copies that had already drifted (the commit types lacked revert).

Add #skip-changelog to the first PR body instead of editing it afterwards, and write PR bodies
to per-branch or per-PR files. The shared /tmp/pr-body.md outlives sessions and once opened a
PR with another PR's body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@runningcode runningcode changed the title fix(skill): Use pr-writer in the create-java-pr skill ref(skill): Defer to the shared Sentry skills in create-java-pr Nov 16, 2026
@runningcode
runningcode marked this pull request as ready for review November 16, 2026 13:43
@runningcode
runningcode requested review from a team and adinauer as code owners November 16, 2026 13:43
@runningcode
runningcode requested review from 0xadam-brown and romtsn and removed request for a team November 16, 2026 13:43
@github-actions github-actions Bot added the risk: low PR risk score: low label Nov 16, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c37c75b. Configure here.

Comment thread .claude/skills/create-java-pr/SKILL.md Resolved
Comment thread .claude/skills/create-java-pr/SKILL.md Resolved
runningcode and others added 2 commits November 17, 2026 10:09
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@adinauer adinauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this could use the wrong tmp file

Comment thread .claude/skills/create-java-pr/SKILL.md Resolved

@0xadam-brown 0xadam-brown left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

@runningcode
runningcode merged commit 1882d93 into main Nov 17, 2026
47 checks passed
@runningcode
runningcode deleted the no/create-java-pr-use-pr-writer branch November 17, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low PR risk score: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants