Skip to content

test(servlet): Verify Servlet 3.1 and 4.0 compatibility - #6624

Open
adinauer wants to merge 3 commits into
mainfrom
chore/servlet-api-compatibility-stack
Open

adinauer wants to merge 3 commits into
mainfrom
chore/servlet-api-compatibility-stack

Conversation

@adinauer

@adinauer adinauer commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

PR Stack (Servlet API)


📜 Description

Keep javax.servlet:javax.servlet-api at 3.1.0 as the production compile target and exclude the intentionally pinned dependency from Dependabot updates.

Add a real-container integration test that runs on both Tomcat 8.5 / Servlet 3.1 and Tomcat 9 / Servlet 4.0.

💡 Motivation and Context

Compiling against the minimum supported Servlet API prevents accidental use of Servlet 4-only APIs. The runtime matrix verifies that the same standalone sentry-servlet integration works at both ends of the supported javax.servlet range.

The existing servlet4-api catalog alias remains available for code that intentionally targets Servlet 4.

💚 How did you test it?

  • make format api
  • ./gradlew :sentry-servlet:integrationTest :sentry-servlet:integrationTestTomcat9 --rerun-tasks --no-build-cache
  • Verified compileClasspath resolves javax.servlet-api:3.1.0
  • Verified the isolated JVM test-suite runtimes resolve Tomcat 8.5.100 and Tomcat 9.0.108 respectively

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.

🔮 Next steps

Merge PR #6625 into this branch with a merge commit, then squash-merge this collection PR into main.

#skip-changelog

@sentry

sentry Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.64.0 (1) release

⚙️ sentry-android Build Distribution Settings

dependabot Bot and others added 2 commits November 17, 2026 08:05
…#6475)

Bumps [javax.servlet:javax.servlet-api](https://github.com/javaee/servlet-spec) from 3.1.0 to 4.0.1.
- [Commits](javaee/servlet-spec@3.1.0...4.0.1)

---
updated-dependencies:
- dependency-name: javax.servlet:javax.servlet-api
  dependency-version: 4.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Compile the javax servlet integrations against the minimum supported API.
Exclude the intentionally pinned API from Dependabot while retaining the
separate Servlet 4 alias for latest-runtime coverage.

Co-Authored-By: Claude <noreply@anthropic.com>
@adinauer adinauer changed the title chore(servlet): Update Servlet API compatibility test(servlet): Verify Servlet 3.1 and 4.0 compatibility Nov 17, 2026
@adinauer
adinauer marked this pull request as ready for review November 17, 2026 13:23
@adinauer
adinauer requested a review from a team as a code owner November 17, 2026 13:23
@adinauer
adinauer requested review from 0xadam-brown and markushi and removed request for a team November 17, 2026 13:23
@github-actions github-actions Bot added the risk: low PR risk score: low label Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low PR risk score: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant