Repository navigation
ci(risk): Grade PRs with sentry-java risk guidance and core-first diffs - #6644
Closed
sentry-junior[bot] wants to merge 1 commit into
Closed
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Nelson Osacky <nelson.osacky@sentry.io>
📲 Install BuildsAndroid
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR Risk (Jev) workflow grades every PR with a generic rubric. It knows nothing about what
.cursor/BUGBOT.mdsays is dangerous here. For example, #6588 changes how ANR, tombstone and app-exit timestamps are read, and it was labeledrisk: low.This PR:
.github/pr-risk.md, a ~3 KB summary of BUGBOT's critical rules, written as mechanisms to look for: crashing or hanging the host app, locks across re-entrant calls, work on the init path, default-on behavior, public API andInternalSentrySdkbreaks, PII withoutsendDefaultPii, transport and protocol changes, version-matrix bumps, and clock misuse. It also lists what is usually low. The workflow passes it asrisk-guidance-path. The action reads it from the base branch, so a PR can't rewrite the rules it's graded by.prioritize-pathsanddeprioritize-paths. On PRs too large for the context budget, Jev currently sees code in path order. Everysentry-*module sorts beforesentry/, so core SDK changes are cut first. Nowsentry/andsentry-android-core/main sources keep their budget first, and tests, samples,.apidumps and the changelog are cut first..github/pr-risk.md, so the two don't drift.Blocked on getsentry/pr-risk-action#9 and getsentry/pr-risk-action#10. Those PRs add the three inputs used here. Before this merges, the
getsentry/pr-risk-action@1cdeab5…pin needs to move to amaincommit that includes both. Until then the action ignores the inputs with an "unexpected input" warning. Like anypull_request_targetworkflow, this one runs frommain, so it takes effect only after merge. The guidance file is read from the base branch, so it starts applying to the PRs opened after this merges.#skip-changelog
via no.
--
View Session [Sentry]