Skip to content

ci(risk): Use the shared SDK risk action and let it publish the label - #6645

Merged
runningcode merged 1 commit into
mainfrom
ci/sdk-pr-risk-action
Nov 18, 2026
Merged

runningcode merged 1 commit into
mainfrom
ci/sdk-pr-risk-action

Conversation

@stephanie-anderson

Copy link
Copy Markdown
Contributor

Switch the PR risk workflow from getsentry/pr-risk-action to getsentry/sdk-pr-risk-action and let the action publish the risk: label itself. The 110-line label script in this workflow goes away.

The SDK action scores with one rubric shared by all SDK repositories instead of the service-oriented one: it asks about host app crashes and hangs, startup and size cost, public API and defaults, data sent to Sentry, and what customers inherit. It reads the sentry-java fact sheet (sdk/repos/getsentry__sentry-java.toml) to know which paths are server, Android, shared core, tests, samples, API records, dependencies or build files. Rules in code can raise low to medium, never lower: truncated input, uninspected binaries, unmapped paths, *.api files, dependency changes, build and release files, and a model probability for low under 0.90. The PR title and description are no longer sent to the model.

What changes for this repo:

  • The high_risk_code rule is not carried over. Since ci(risk): Never label PRs touching high-risk files as low risk #6643, a PR touching one of the six files in .github/file-filters.yml could never be low. The shared rules do not know that list, so a comment-only change to one of those files can now be low. The "Changes In High Risk Code" comment workflow is untouched. If we want to keep the guarantee, it needs a per-repo "never low" list in the fact sheet format; I'd rather add that to the action than keep a second label writer here.
  • Drafts are scored, and converting to draft starts a run, so a draft never keeps a label from an earlier revision.
  • workflow_dispatch is removed. A manual run has no expected head SHA, which matters once the label is used to reduce review.
  • Permissions move to the job, with permissions: {} at the top, and runs are no longer cancelled in progress so every started run reaches its label clear.

The action is pinned to 46f2c96, the current main of the new repo. Label publishing has been unit-tested but this PR is its first run against live pull requests, and because the workflow uses pull_request_target it only takes effect after merge.

#skip-changelog

🤖 Generated with Claude Code

Switch from getsentry/pr-risk-action to getsentry/sdk-pr-risk-action, which
scores with the rubric shared by all SDK repositories and the sentry-java
fact sheet, and publishes the risk label itself. This removes the label
script from this workflow.

The script's rule that files in high_risk_code are never low is not carried
over; the shared rules block low for public API records, dependency and
build files, unmapped paths and low model confidence instead.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@sentry

sentry Bot commented Nov 17, 2026

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.65.0 (1) release

⚙️ sentry-android Build Distribution Settings

@runningcode
runningcode marked this pull request as ready for review November 18, 2026 07:34
@runningcode
runningcode requested review from a team and adinauer as code owners November 18, 2026 07:34
@runningcode
runningcode requested review from 0xadam-brown and runningcode and removed request for a team November 18, 2026 07:34
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 18, 2026
@runningcode

runningcode commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

I say we try it out. It'll surely be better than the existing one! I might do a follow up for the high_risk_code thing.

@runningcode
runningcode merged commit c2c0396 into main Nov 18, 2026
49 checks passed
@runningcode
runningcode deleted the ci/sdk-pr-risk-action branch November 18, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants