Repository navigation
ci(risk): Use the shared SDK risk action and let it publish the label - #6645
Merged
Merged
Conversation
Switch from getsentry/pr-risk-action to getsentry/sdk-pr-risk-action, which scores with the rubric shared by all SDK repositories and the sentry-java fact sheet, and publishes the risk label itself. This removes the label script from this workflow. The script's rule that files in high_risk_code are never low is not carried over; the shared rules block low for public API records, dependency and build files, unmapped paths and low model confidence instead. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
📲 Install BuildsAndroid
|
runningcode
marked this pull request as ready for review
November 18, 2026 07:34
runningcode
requested review from
0xadam-brown and
runningcode
and removed request for
a team
November 18, 2026 07:34
Contributor
|
I say we try it out. It'll surely be better than the existing one! I might do a follow up for the high_risk_code thing. |
runningcode
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the PR risk workflow from
getsentry/pr-risk-actiontogetsentry/sdk-pr-risk-actionand let the action publish therisk:label itself. The 110-line label script in this workflow goes away.The SDK action scores with one rubric shared by all SDK repositories instead of the service-oriented one: it asks about host app crashes and hangs, startup and size cost, public API and defaults, data sent to Sentry, and what customers inherit. It reads the sentry-java fact sheet (
sdk/repos/getsentry__sentry-java.toml) to know which paths are server, Android, shared core, tests, samples, API records, dependencies or build files. Rules in code can raise low to medium, never lower: truncated input, uninspected binaries, unmapped paths,*.apifiles, dependency changes, build and release files, and a model probability for low under 0.90. The PR title and description are no longer sent to the model.What changes for this repo:
high_risk_coderule is not carried over. Since ci(risk): Never label PRs touching high-risk files as low risk #6643, a PR touching one of the six files in.github/file-filters.ymlcould never be low. The shared rules do not know that list, so a comment-only change to one of those files can now be low. The "Changes In High Risk Code" comment workflow is untouched. If we want to keep the guarantee, it needs a per-repo "never low" list in the fact sheet format; I'd rather add that to the action than keep a second label writer here.workflow_dispatchis removed. A manual run has no expected head SHA, which matters once the label is used to reduce review.permissions: {}at the top, and runs are no longer cancelled in progress so every started run reaches its label clear.The action is pinned to
46f2c96, the currentmainof the new repo. Label publishing has been unit-tested but this PR is its first run against live pull requests, and because the workflow usespull_request_targetit only takes effect after merge.#skip-changelog
🤖 Generated with Claude Code