Repository navigation
build(android): [AGP New DSL 3] Use AGP's new DSL - #6655
Draft
runningcode wants to merge 2 commits into
Draft
runningcode wants to merge 2 commits into
runningcode wants to merge 2 commits into
Conversation
Build-logic and the module build scripts already use only the com.android.build.api DSL and Variant API types, so dropping the android.newDsl=false opt-out is enough. The published artifacts are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Finalize the variant's assemble and install tasks by name, so the sample doesn't depend on a non-stable impl class. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 18, 2026
📲 Install BuildsAndroid
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (AGP New DSL 9.x.x)
📜 Description
Drops the
android.newDsl=falseopt-out, so the build runs on AGP's new DSL.Build-logic and the module build scripts already use only the
com.android.build.apiDSL and Variant API types. The legacyBaseExtensionconfiguration the issue mentions is gone from the root build, so removing the flag is enough there.The Android sample cast its variants to AGP's internal
VariantImplto finalize theassembleandinstalltasks with the native-logging toggle. It now matches those tasks by name, lazily and withoutafterEvaluate.💡 Motivation and Context
AGP 10 removes
android.newDsl=false.💚 How did you test it?
androidextension is AGP's newLibraryExtensionImpl, not the legacyBaseExtension, with the flag gone.checkon all 13 Android modules andsentry-test-support, the samples build, both Android sample variants, both UI test apps andtest-app-size..modulefiles are byte-identical, and the AARs and jars have the same entries and sizes.toggle<Variant>NativeLoggingstill finalizesassembleDebug,assembleReleaseandinstallDebugin the sample.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
None.
🤖 Generated with Claude Code
#skip-changelog