Repository navigation
ci: Run the Playwright install's npx outside the repo - #25384
Merged
Merged
Conversation
mydea
added this pull request to stack #25385
October 15, 2026 07:44
mydea
force-pushed
the
ci/playwright-background-installs
branch
from
October 15, 2026 11:36
fbff338 to
3db934a
Compare
mydea
removed this pull request from stack #25385
October 15, 2026 11:37
mydea
added this pull request to stack #25392
October 15, 2026 11:37
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mydea
force-pushed
the
ci/playwright-background-installs
branch
from
October 15, 2026 11:58
3db934a to
0f7f0c2
Compare
mydea
removed this pull request from stack #25392
October 15, 2026 11:58
mydea
added this pull request to stack #25397
October 15, 2026 11:58
mydea
force-pushed
the
ci/playwright-background-installs
branch
from
October 15, 2026 12:51
0f7f0c2 to
c7d2498
Compare
mydea
removed this pull request from stack #25397
October 15, 2026 12:51
mydea
added this pull request to stack #25401
October 15, 2026 12:52
mydea
removed this pull request from stack #25401
October 15, 2026 12:55
mydea
added this pull request to stack #25405
October 15, 2026 12:56
mydea
force-pushed
the
ci/playwright-background-installs
branch
2 times, most recently
from
October 16, 2026 07:35
963293b to
7eb95ee
Compare
mydea
force-pushed
the
ci/playwright-background-installs
branch
from
October 16, 2026 08:52
7eb95ee to
ba0a952
Compare
mydea
force-pushed
the
ci/playwright-background-installs
branch
from
October 16, 2026 09:16
ba0a952 to
5577460
Compare
mydea
force-pushed
the
ci/playwright-background-installs
branch
from
October 19, 2026 08:17
5577460 to
5d48b33
Compare
mydea
force-pushed
the
ci/playwright-background-installs
branch
from
October 19, 2026 09:06
5d48b33 to
c450ff9
Compare
mydea
force-pushed
the
ci/playwright-background-installs
branch
2 times, most recently
from
October 19, 2026 09:36
380107c to
0866079
Compare
mydea
changed the title
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0866079. Configure here.
From the repo root, npx could pick up a hoisted playwright that a parallel pnpm install was still linking, and fail with "playwright: not found". Also pass the browsers to install-deps as separate arguments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
ci/playwright-background-installs
branch
from
October 20, 2026 07:38
f36bed0 to
4d79642
Compare
mydea
changed the title
mydea
marked this pull request as ready for review
October 20, 2026 07:58
JPeer264
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install-playwrightrannpx playwright@<version>from the repo root. WithnodeLinker: hoisted, npm can findnode_modules/playwrightthere before pnpm has linked its binary, so apnpm installrunning in parallel made it fail withplaywright: not found. E2E jobs no longer install the workspace since #25514, but the action also runs in other jobs, so it now runsnpxinrunner.temp. It also passes the browsers toinstall-depsas separate arguments, which only mattered for the multi-browser default.The original change here, starting the background install before the E2E setup steps, is dropped. #25514 moved it right before the build, because a background composite action crashes the runner with "Collection was modified" when a foreground step starts while it sets up.
🤖 Generated with Claude Code