Repository navigation
Conversation
323db37 to
776be29
Compare
size-limit report 📦Compared: 12757d0 (PR test merge using develop at 287ad6a) Against: d4a4e81 (develop) · base run #62971
|
776be29 to
e0f36f5
Compare
4a248fa to
37afe7c
Compare
37afe7c to
03d8225
Compare
03d8225 to
3e455f4
Compare
3e455f4 to
fa2d7a6
Compare
fa2d7a6 to
034ec1f
Compare
034ec1f to
b254fc1
Compare
b254fc1 to
b8540c7
Compare
|
bugbot run |
b8540c7 to
a729215
Compare
|
bugbot run |
1 similar comment
|
bugbot run |
a729215 to
bcba572
Compare
52c1093 to
26d2e6e
Compare
2531891 to
5ae1c71
Compare
5ae1c71 to
2cd301c
Compare
|
|
||
| const DSN = 'https://username@domain/123'; | ||
|
|
||
| Deno.test('Deno.serve drops the server span of managed tunnel requests', async () => { |
There was a problem hiding this comment.
q: Do we need this test? Theoretically the node integration tests should run under deno too, so this unit test would be a duplication 🤔
There was a problem hiding this comment.
Ah okay, I'm moving both of these tests to their runtime's own tests.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 74fe197. Configure here.
|
One or more gzipped bundles increased by more than 500 bytes. If this increase is intentional, add the Accept Bundlesize Increase label to this PR to rerun and accept the check. |
Optional E2E testsAll optional checks were successful. 6 successful. See the run. Successful checks
|
…uests Meta-framework SDKs answer the tunnel requests. Cloudflare, Node, Bun and Deno only translate `tunnel: true` so the core client drops the server span they create for them, which these tests pin down.

Runtimes only translate
tunnel: truewhile meta-frameworks answer the requests, so nothing pinned down that their server spans get dropped.This PR asserts that runtime SDKs level (Cloudflare, Node, Bun and Deno) ignores the tunneled span so we don't have to chase it around. This is one benefit of having tunnels as a core SDK capability, this PR just tests that.
Node, Deno and Cloudflare live in their integration test suites, and Bun is a unit test in its package.
For reviewers: if you need an overview of what this is, refer to #25199.
closes #25462