Repository navigation
test(replay): Fix flaky EventBufferCompressionWorker size limit test - #25519
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
mydea
marked this pull request as ready for review
October 19, 2026 14:09
mydea
requested review from
Lms24 and
logaretm
and removed request for
a team
October 19, 2026 14:10
Contributor
size-limit report 📦Compared: 8faf10e (PR test merge using develop at d4a4e81) Against: ca4fc32 (develop) · base run #62950
|
Co-Authored-By: Francesco Gringl-Novy <francesco.novy@sentry.io>
mydea
force-pushed
the
test/replay-flaky-compression-worker-clear
branch
from
October 21, 2026 15:27
18474fa to
a7bcf58
Compare
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 3 failing, 28 successful. See the run.
Successful checks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
size limittests inEventBufferCompressionWorker.test.tsbuild events sized against the realREPLAY_MAX_EVENT_BUFFER_SIZE(~20MB). That pushes 13–20MB of JSON throughjsdom-workerand fflate on every test, in the same process. The tests don't hang. They're just CPU-bound, taking 6–11s on a busy CI runner, so they sometimes go over the 10s timeout. "resets size limit on clear" failed twice ondevelopthis way. Under CPU load locally I could reproduce the sameTest timed out in 10000ms.The size check is a plain counter in
EventBufferCompressionWorker, so the actual byte count doesn't matter. This mocksREPLAY_MAX_EVENT_BUFFER_SIZEto 100kB for this file, the same approachtest/integration/eventBuffer.test.tsalready uses. The custom 10s timeout is gone because it's no longer needed. The tests now run in ~15ms each, and they still fail ifclear()stops resetting the size counter.via Francesco Gringl-Novy.
--
View Junior Session [Sentry]