Repository navigation
fix(aws-serverless): End the function.aws span when a callback-style handler calls back - #25543
Merged
JPeer264 merged 2 commits intoOct 21, 2026
Merged
Conversation
…e handler calls back
4ktLuffy
requested review from
JPeer264 and
mydea
and removed request for
a team
October 19, 2026 19:18
…ck-style handler calls back
JPeer264
approved these changes
Oct 21, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for fixing that. I added an E2E test for it that is also covered there
Member
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit dd043a5. Configure here.
nicohrubec
pushed a commit
that referenced
this pull request
Oct 21, 2026
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #25543 Co-authored-by: JPeer264 <10677263+JPeer264@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For callback-style handlers the
function.awsspan ended as soon as the handler returned, so it had ~0 ms duration andokstatus even whencallback(err)came later. If the handler takes a callback and doesn't return a promise, the span is now ended by the wrapped callback instead. Tests call back from asetTimeoutwith a result and with an error.