Repository navigation
fix(server-runtime-injection): Load ESM hook without the build/esm package.json marker - #25562
Merged
Merged
Conversation
…ckage.json marker Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: 5dbf07c (PR test merge using develop at 2028b68) Against: 2028b68 (develop) · base run #62870 ✅ Baseline matches: this diff contains only this PR's changes.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5084a8e. Configure here.
andreiborza
marked this pull request as ready for review
October 21, 2026 09:36
andreiborza
requested review from
isaacs,
mydea and
timfish
and removed request for
a team
October 21, 2026 09:36
mydea
approved these changes
Oct 21, 2026
mydea
left a comment
mydea
left a comment
Member
There was a problem hiding this comment.
funky, but I guess if it works...
Member
Author
|
Yep, I tested this by deploying to Vercel and it does work. Also the added test fails without the fix. |
51 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The diagnostics-channel hook now loads as ESM even when
build/esm/package.jsonis missing from a deployment.Why
Vercel runs Node 22 with syntax detection off, so without that file the hook failed to load and channel-based spans were lost.
Closes: #25480