Skip to content

fix(v10/core): Drop sampled-out errors before they take a promise buffer slot - #25753

Open
logaretm wants to merge 2 commits into
v10from
awad/v10-sample-errors-before-buffer
Open

logaretm wants to merge 2 commits into
v10from
awad/v10-sample-errors-before-buffer

Conversation

@logaretm

Copy link
Copy Markdown
Member

Backport of: #25751

Differences to the original PR

  • packages/core/test/lib/client.test.ts: the "does not set lastEventId" test passes an explicit event_id and asserts lastEventId() isn't it, instead of asserting undefined. v10's test setup doesn't reset lastEventId between tests, so an earlier test's ID leaks in.

@logaretm

Copy link
Copy Markdown
Member Author

bugbot run

@logaretm
logaretm marked this pull request as ready for review October 27, 2026 02:49
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.32 kB added added
@sentry/browser - with treeshaking flags 26.77 kB added added
@sentry/browser (incl. Tracing) 47.33 kB added added
@sentry/browser (incl. Tracing + Span Streaming) 49.13 kB added added
@sentry/browser (incl. Tracing, Profiling) 52.11 kB added added
@sentry/browser (incl. Tracing, Replay) 86.79 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 76.42 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 91.5 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 104.12 kB added added
@sentry/browser (incl. Feedback) 45.5 kB added added
@sentry/browser (incl. sendFeedback) 33.13 kB added added
@sentry/browser (incl. FeedbackAsync) 38.25 kB added added
@sentry/browser (incl. Metrics) 29.41 kB added added
@sentry/browser (incl. Logs) 29.64 kB added added
@sentry/browser (incl. Metrics & Logs) 30.33 kB added added
@sentry/react 30.14 kB added added
@sentry/react (incl. Tracing) 49.63 kB added added
@sentry/vue 34.21 kB added added
@sentry/vue (incl. Tracing) 49.7 kB added added
@sentry/svelte 28.34 kB added added
CDN Bundle 30.73 kB added added
CDN Bundle (incl. Tracing) 49.3 kB added added
CDN Bundle (incl. Logs, Metrics) 32.33 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) 50.62 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) 71.82 kB added added
CDN Bundle (incl. Tracing, Replay) 87.03 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.33 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 92.84 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.12 kB added added
CDN Bundle - uncompressed 91.31 kB added added
CDN Bundle (incl. Tracing) - uncompressed 148.57 kB added added
CDN Bundle (incl. Logs, Metrics) - uncompressed 96.02 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.55 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 221.51 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 268.53 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 272.5 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 282.23 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 286.19 kB added added
@sentry/nextjs (client) 52.3 kB added added
@sentry/sveltekit (client) 47.77 kB added added
@sentry/core/server 81.71 kB added added
@sentry/core/browser 67.76 kB added added
@sentry/node-core 64.13 kB added added
@sentry/node 127.32 kB added added
@sentry/node (incl. diagnostics channel injection) 171.5 kB added added
@sentry/node/import (ESM hook with diagnostics-channel injection) 166 B added added
@sentry/node/light 52.23 kB added added
@sentry/node - without tracing 75.92 kB added added
@sentry/aws-serverless 85.08 kB added added
@sentry/cloudflare (withSentry) - minified 205.06 kB added added
@sentry/cloudflare (withSentry) 505.55 kB added added

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant