Skip to content

fix(server-utils): Read the pi-durable session id in every phase outside a run - #25838

Merged
JPeer264 merged 1 commit into
developfrom
jp/pi-durable-session-id-outside-runs
Oct 28, 2026
Merged

JPeer264 merged 1 commit into
developfrom
jp/pi-durable-session-id-outside-runs

Conversation

@JPeer264

Copy link
Copy Markdown
Member

follow up to #25792

This makes every pi-durable phase outside a run read the stored session id, not only an idle compaction.

Why

An extension task that calls the model while its conversation has no run in progress kept the <harnessId>:<n> id. The runs of the same conversation report the session id, so Sentry showed the task as a separate conversation.

…ide a run

A task of an extension that calls the model while its conversation is
idle kept the harness-prefixed conversation id. Its spans then showed as
a conversation of their own, apart from the runs, which report the
stored session id. Every phase outside a run now reads the session id.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: 4c58380 (PR test merge using develop at 0455361)

Against: 0455361 (develop) · base run #63985

✅ Baseline matches: this diff contains only this PR's changes.

Path Size % Change Change
@sentry/browser 30.34 kB - -
@sentry/browser - with treeshaking flags 28.46 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.35 kB - -
@sentry/browser (incl. Tracing) 52.61 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.62 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.54 kB - -
@sentry/browser (incl. Tracing, Replay) 92.81 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.43 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.54 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.52 kB - -
@sentry/browser (incl. Feedback) 47.9 kB - -
@sentry/browser (incl. sendFeedback) 35.41 kB - -
@sentry/browser (incl. FeedbackAsync) 40.52 kB - -
@sentry/browser (incl. Metrics) 31.35 kB - -
@sentry/browser (incl. Logs) 31.63 kB - -
@sentry/browser (incl. Metrics & Logs) 32.31 kB - -
@sentry/react 32.16 kB - -
@sentry/react (incl. Tracing) 54.89 kB - -
@sentry/vue 38.61 kB - -
@sentry/vue (incl. Tracing) 55.5 kB - -
@sentry/svelte 30.37 kB - -
@sentry/remix (Remix 3 client bundle) 57.65 kB - -
CDN Bundle 32.07 kB - -
CDN Bundle (incl. Tracing) 53.1 kB - -
CDN Bundle (incl. Logs, Metrics) 34.27 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.05 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.69 kB - -
CDN Bundle (incl. Tracing, Replay) 91.23 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.17 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 97.36 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 99.34 kB - -
CDN Bundle - uncompressed 94.31 kB - -
CDN Bundle (incl. Tracing) - uncompressed 157.3 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.86 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.27 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 232.36 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 278.93 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 284.88 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 292.63 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 298.58 kB - -
@sentry/nextjs (client) 57.75 kB - -
@sentry/sveltekit (client) 53.06 kB - -
@sentry/core/server 44.29 kB - -
@sentry/core/browser 13.95 kB - -
@sentry/node 155.02 kB -0.01% -9 B 🔽
@sentry/node/import (ESM hook with diagnostics-channel injection) 81.67 kB - -
@sentry/node - without tracing 95.77 kB +0.01% +7 B 🔺
@sentry/node - without channel injection 135.66 kB +0.01% +2 B 🔺
@sentry/aws-serverless 103.94 kB +0.01% +7 B 🔺
@sentry/cloudflare (withSentry) - minified 197.89 kB - -
@sentry/cloudflare (withSentry) 491.82 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 218.47 kB - -

View base workflow run

@github-actions

Copy link
Copy Markdown
Contributor

Optional E2E tests

Some optional checks were not successful. They do not block the merge. 5 not successful, 57 successful. See the run.

Check Status
❌ CI: Optional E2E Tests / E2E node-anthropic-send-to-sentry (latest) Test (optional) Failing after 3m Details
❌ CI: Optional E2E Tests / E2E cloudflare-workers-send-to-sentry Test (optional) Failing after 5m Details
❌ CI: Optional E2E Tests / E2E node-express-send-to-sentry-static Test (optional) Failing after 3m Details
❌ CI: Optional E2E Tests / E2E node-openai-decisions-send-to-sentry Test (optional) Failing after 3m Details
❌ CI: Optional E2E Tests / E2E node-flue-send-to-sentry (latest) Test (optional) Failing after 3m Details
Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E astro-7-static Test (optional) Successful in 52s Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (canary, webpack) Test (optional) Successful in 5m Details
✅ CI: Optional E2E Tests / E2E debug-id-sourcemaps Test (optional) Successful in 52s Details
✅ CI: Optional E2E Tests / E2E astro-7 Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (deno) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E cloudflare-pi-durable (latest) Test (optional) Successful in 37s Details
✅ CI: Optional E2E Tests / E2E nextjs-16-tunnel (cloudflare) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E cloudflare-agent Test (optional) Successful in 47s Details
✅ CI: Optional E2E Tests / E2E nextjs-orpc Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E cloudflare-think Test (optional) Successful in 50s Details
✅ CI: Optional E2E Tests / E2E deno (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (canary, turbopack) Test (optional) Successful in 4m Details
✅ CI: Optional E2E Tests / E2E cloudflare-think (ai v6) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-fastify-6 (tracer provider) Test (optional) Successful in 37s Details
✅ CI: Optional E2E Tests / E2E cloudflare-mastra Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16-standalone (canary, turbopack) Test (optional) Successful in 38s Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-14 (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E cloudflare-pi-durable Test (optional) Successful in 26s Details
✅ CI: Optional E2E Tests / E2E cloudflare-flue-send-to-sentry Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (turbo) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nextjs-15 (latest) Test (optional) Successful in 3m Details
✅ CI: Optional E2E Tests / E2E node-eve (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext, bun) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-eve Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (client source maps kept) Test (optional) Successful in 34s Details
✅ CI: Optional E2E Tests / E2E node-pi-durable Test (optional) Successful in 50s Details
✅ CI: Optional E2E Tests / E2E node-anthropic-send-to-sentry Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E gen-ai-libraries (cloudflare) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-14 (canary) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (vinext) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nextjs-16 (cloudflare, latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-sourcemaps Test (optional) Successful in 28s Details
✅ CI: Optional E2E Tests / E2E node-express-mcp-v2 Test (optional) Successful in 28s Details
✅ CI: Optional E2E Tests / E2E node-flue (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-3 (canary) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-4-static (canary) Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E nuxt-5 Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E node-flue-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-fastify-6 Test (optional) Successful in 29s Details
✅ CI: Optional E2E Tests / E2E node-openai-send-to-sentry Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E react-router-7-framework-instrumentation Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E solidstart-2 Test (optional) Successful in 44s Details
✅ CI: Optional E2E Tests / E2E node-eve (orchestrion) Test (optional) Successful in 42s Details
✅ CI: Optional E2E Tests / E2E node-express-mcp-v1 Test (optional) Successful in 19s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) Successful in 26s Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (static / nuxt generate) Test (optional) Successful in 23s Details
✅ CI: Optional E2E Tests / E2E supabase-nextjs Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-openai-decisions-send-to-sentry (latest) Test (optional) Successful in 3m Details
✅ CI: Optional E2E Tests / E2E nuxt-4 (canary) Test (optional) Successful in 3m Details
✅ CI: Optional E2E Tests / E2E node-mastra (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-pi-durable (latest) Test (optional) Successful in 26s Details
✅ CI: Optional E2E Tests / E2E node-openai-send-to-sentry (latest) Test (optional) Successful in 3m Details
✅ CI: Optional E2E Tests / E2E node-mastra Test (optional) Successful in 47s Details
✅ CI: Optional E2E Tests / E2E node-express-send-to-sentry Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E node-flue Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps Test (optional) Successful in 23s Details

@JPeer264
JPeer264 marked this pull request as ready for review October 28, 2026 21:40
@JPeer264
JPeer264 requested a review from a team as a code owner October 28, 2026 21:40
@JPeer264
JPeer264 requested review from isaacs and mydea and removed request for a team October 28, 2026 21:40
@JPeer264
JPeer264 merged commit 2b1607d into develop Oct 28, 2026
319 of 324 checks passed
@JPeer264
JPeer264 deleted the jp/pi-durable-session-id-outside-runs branch October 28, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants