Repository navigation
Conversation
Renames node-openai-decisions-send-to-sentry to node-openai-decisions and asserts the gen_ai.decide spans at the local event proxy instead of polling the Sentry API. The app still calls the real Decisions API. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: b149dce (PR test merge using develop at b382e30) Against: b382e30 (develop) · base run #63998 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 66 successful. See the run.
Successful checks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Whether gen_ai spans arrive in Sentry isn't something we need to test for each AI integration, but this app is still the only one that calls the real OpenAI Decisions API (OpenRouter has no
/decisionsroute), so it stays, renamed, and checks thegen_ai.decidespans at the local event proxy instead of polling the Sentry API. The tests now wait about 90s at most instead of up to ~6min.How to review: The assertions are the same as before, but they use the attribute names the SDK sends (
sentry.origin,gen_ai.*) instead of the names Sentry stores, and integers are numbers instead of strings. TheE2E_OPENAI_DECISIONS_API_KEYscoping inoptional-e2e.ymlnow uses the new app name.Unsure about: I couldn't run this locally (no Decisions key), so the first optional E2E run on this PR is its first run.
🤖 Generated with Claude Code