Skip to content

[0.17] feat(sync): add read-write lock primitive - #1877

Open
jpnurmi wants to merge 1 commit into
jpnurmi/ref/attachmentsfrom
jpnurmi/perf/rwlock
Open

[0.17] feat(sync): add read-write lock primitive#1877
jpnurmi wants to merge 1 commit into
jpnurmi/ref/attachmentsfrom
jpnurmi/perf/rwlock

Conversation

@jpnurmi

@jpnurmi jpnurmi commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Add sentry_rwlock_t backed by platform native RW locks.

#skip-changelog (internal)

@jpnurmi jpnurmi changed the title perf: use recursive rwlock for global scope [WIP] perf: use recursive rwlock for global scope Jul 16, 2026
Comment thread src/sentry_sync.h Outdated
Comment thread src/sentry_sync.h Outdated
@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.50%. Comparing base (b4d7fb8) to head (219277a).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           jpnurmi/ref/attachments    #1877      +/-   ##
===========================================================
+ Coverage                    74.47%   74.50%   +0.03%     
===========================================================
  Files                          103      103              
  Lines                        26875    26920      +45     
  Branches                      4876     4880       +4     
===========================================================
+ Hits                         20014    20058      +44     
+ Misses                        5532     5531       -1     
- Partials                      1329     1331       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/sentry_sync.h Outdated
Comment thread src/sentry_scope.c
Comment thread src/sentry_sync.h Outdated
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/rwlock branch from 495cd85 to 05fe336 Compare August 7, 2026 14:42
@jpnurmi jpnurmi changed the title [WIP] perf: use recursive rwlock for global scope [WIP] perf: use rwlock for scope data access Aug 7, 2026
Comment thread src/sentry_scope.c Outdated
Comment thread src/sentry_options.h
Comment thread src/sentry_attachment.c
Comment thread src/backends/sentry_backend_breakpad.cpp
Comment thread src/sentry_scope.c Outdated
Comment thread src/sentry_scope.c Outdated
Comment thread src/sentry_attachment.c Outdated
Comment thread src/sentry_scope.c Outdated
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/rwlock branch from 3c7c966 to 4948141 Compare August 12, 2026 04:55
@jpnurmi
jpnurmi changed the base branch from master to jpnurmi/ref/attachments August 12, 2026 04:56
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/rwlock branch from 4948141 to 0b0e77c Compare August 12, 2026 06:33
Comment thread src/sentry_scope.c Outdated
Comment thread src/sentry_scope.c Outdated
Comment thread src/sentry_scope.c Outdated
Comment thread src/sentry_scope.c Outdated
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/rwlock branch from dab304d to b899738 Compare August 17, 2026 17:52
Comment thread src/sentry_scope.c Outdated
Comment thread src/integrations/sentry_integration_wer.c Outdated
Comment thread src/sentry_core.c Outdated
Comment thread src/sentry_scope.c Outdated
Comment thread src/sentry_scope.c Outdated
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/rwlock branch from 853172c to dcbac0c Compare August 18, 2026 12:37
Comment thread src/sentry_scope.c
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/rwlock branch from 8891408 to f197136 Compare August 19, 2026 10:05
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/rwlock branch 2 times, most recently from 802a09a to abcc49d Compare August 19, 2026 11:29
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/rwlock branch from 135c53c to fd41b34 Compare August 20, 2026 16:26

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fd41b34. Configure here.

Comment thread src/backends/sentry_backend_native.c Outdated
Comment thread src/sentry_scope.c
@jpnurmi jpnurmi changed the title [WIP] perf: use rwlock for scope data access [0.17] perf: use rwlock for scope data access Aug 26, 2026
Add `sentry_rwlock_t` backed by platform native RW locks.
@jpnurmi
jpnurmi force-pushed the jpnurmi/perf/rwlock branch from fd41b34 to 219277a Compare September 1, 2026 14:41
Comment thread src/sentry_sync.h
@jpnurmi jpnurmi changed the title [0.17] perf: use rwlock for scope data access [0.17] feat(sync): add read-write lock primitive Sep 1, 2026
@jpnurmi jpnurmi mentioned this pull request Sep 2, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant