Skip to content

ci(warden): Add code-review skill - #2385

Merged
Litarnus merged 2 commits into
masterfrom
ci/warden-code-review
Nov 17, 2026
Merged

Litarnus merged 2 commits into
masterfrom
ci/warden-code-review

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Adds a warden.toml that runs Warden's built-in code-review skill on PRs, alongside the org-wide security-review. warden.toml is also marked export-ignore in .gitattributes so it doesn't ship in the package dist.

The trigger has no draft = false filter on purpose, so PRs that go from draft to ready don't get missed. The org Warden workflow is a ruleset-required workflow, and GitHub only runs those on opened, synchronize, and reopened (docs), whatever types they list. So ready_for_review never reaches Warden, and with a draft filter a PR opened as a draft and marked ready without a new push would never be reviewed. Reviewing drafts as commits land means the PR is already reviewed when it leaves draft. incremental = true keeps each push limited to what changed since the last run. getsentry/sentry-dotnet#5944 made the same change for the same reason.

phpstan-baseline.neon and analysis-baseline.toml (Mago) are ignored since they're generated baselines.

via Martin Linzmayer.

--

View Session [Sentry]

Co-Authored-By: Martin Linzmayer <martin.linzmayer@sentry.io>
@sentry-junior
sentry-junior Bot marked this pull request as ready for review November 17, 2026 14:06
@sentry-junior
sentry-junior Bot requested review from a team and stayallive as code owners November 17, 2026 14:06
Co-Authored-By: Martin Linzmayer <martin.linzmayer@sentry.io>
@Litarnus
Litarnus merged commit 24a728f into master Nov 17, 2026
59 of 61 checks passed
@Litarnus
Litarnus deleted the ci/warden-code-review branch November 17, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant