chore(graphene): Drop transaction-based tracing - #7221
Open
pnagre05 wants to merge 2 commits into
Open
Conversation
pnagre05
marked this pull request as draft
August 17, 2026 21:58
pnagre05
marked this pull request as ready for review
August 17, 2026 22:39
pnagre05
marked this pull request as draft
August 17, 2026 23:01
Contributor
|
Hey @pnagre05, I had a quick look and the PR looks good. Looks like there would be some reformatting by ruff: Please run ruff on the changes. You can also install pre-commit and let it automatically run all the linting checks before committing. Guides how to do both should be in our CONTRIBUTING.md. Feel free to set this as ready for review once the linting is green locally. |
Author
|
Made the changes, marking it as ready for review now |
pnagre05
marked this pull request as ready for review
August 18, 2026 22:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I removed the transaction-based tracing fallback from the graphene integration - I did this by doing the following
is_span_streaming_enabledbranching and enforces the unconditional use ofsentry_sdk.traces.start_spanelse:fallback blocks and the legacy__exit__context manager calls_span_streamingsuffixesIssues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)