Skip to content

chore(graphene): Drop transaction-based tracing - #7221

Open
pnagre05 wants to merge 2 commits into
getsentry:major/3.0from
pnagre05:pnagre/major/remove-transactions-graphene
Open

chore(graphene): Drop transaction-based tracing#7221
pnagre05 wants to merge 2 commits into
getsentry:major/3.0from
pnagre05:pnagre/major/remove-transactions-graphene

Conversation

@pnagre05

Copy link
Copy Markdown

Description

I removed the transaction-based tracing fallback from the graphene integration - I did this by doing the following

  • Removed all is_span_streaming_enabled branching and enforces the unconditional use of sentry_sdk.traces.start_span
  • Removed legacy compatibility utilities like the else: fallback blocks and the legacy __exit__ context manager calls
  • Deleted obsolete transaction-based tests and promotes the span streaming tests to standard tests by removing their _span_streaming suffixes

Issues

Reminders

@pnagre05
pnagre05 requested a review from a team as a code owner August 17, 2026 21:55
@pnagre05
pnagre05 marked this pull request as draft August 17, 2026 21:58
@pnagre05
pnagre05 marked this pull request as ready for review August 17, 2026 22:39
@pnagre05
pnagre05 marked this pull request as draft August 17, 2026 23:01
@sentrivana

Copy link
Copy Markdown
Contributor

Hey @pnagre05, I had a quick look and the PR looks good.

Looks like there would be some reformatting by ruff:

Run uv run ruff format --check tests sentry_sdk
warning: No `requires-python` value found in the workspace. Defaulting to `>=3.14`.
unformatted: File would be reformatted
   --> tests/integrations/graphene/test_graphene.py:444:54
    |
443 |
    - def test_breadcrumbs_hold_query_information_on_error(
    -     sentry_init, capture_items
    - ):
444 + def test_breadcrumbs_hold_query_information_on_error(sentry_init, capture_items):
445 |     sentry_init(
    |

1 file would be reformatted, 464 files already formatted
Error: Process completed with exit code 1.

Please run ruff on the changes. You can also install pre-commit and let it automatically run all the linting checks before committing. Guides how to do both should be in our CONTRIBUTING.md.

Feel free to set this as ready for review once the linting is green locally.

@pnagre05

Copy link
Copy Markdown
Author

Made the changes, marking it as ready for review now

@pnagre05
pnagre05 marked this pull request as ready for review August 18, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants