Repository navigation
fix(otlp)!: Don't set up a propagator by default - #8201
Merged
Merged
Conversation
Per the OTLP integration spec, the OTLPIntegration must not set up an automatic propagator. Remove the setup_propagator option and stop replacing the global textmap with SentryOTLPPropagator. The propagator stays available for manual setup. Closes #6732 Co-Authored-By: Ivana Kellyer <ivana.kellyer@sentry.io>
Collaborator
|
@sentry-junior Let's follow the ruby approach of setting the propagator to False by default. Don't remove it outright |
sentry-junior
Bot
changed the title
Contributor
Coverage Results 📊✅ 57871 passed | ⏭️ 3012 skipped | Total: 60883 | Pass Rate: 95.05% | Execution Time: 157m 8s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 80%). Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## master #8201 +/-##
==========================================
+ Coverage 90.28% 90.37% +0.09%
==========================================
Files 203 199 -4
Tracked lines 26953 21337 -5616
Branches 10066 7378 -2688
==========================================
- Hits 24334 19282 -5052
+ Misses 2619 2055 -564
+ Partials 1524 1233 -291Generated by Coverage Action |
Collaborator
|
@sentry-junior Unstack this PR with major/3.0. They should be independent |
Follow the sentry-ruby approach (getsentry/sentry-ruby#3063) and keep setup_propagator as an opt-in instead of removing it. Co-Authored-By: Ivana Kellyer <ivana.kellyer@sentry.io>
sentry-junior
Bot
force-pushed
the
ivana/otlp-remove-propagator
branch
from
November 6, 2026 10:02
a3eef1a to
48a5db2
Compare
sentrivana
marked this pull request as ready for review
November 10, 2026 12:14
alexander-alderman-webb
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The OTLP integration spec says the integration MUST NOT set up an automatic propagator. Cross-service propagation should come from the user's OpenTelemetry propagators instead.
Right now
OTLPIntegrationreplaces the global OTel textmap withSentryOTLPPropagatorby default. That means outgoing requests carry onlysentry-trace/baggageand drop the W3Ctraceparent.This follows the sentry-ruby approach (getsentry/sentry-ruby#3063):
setup_propagatornow defaults toFalse, so by defaultOTLPIntegrationleaves the global textmap alone. Users can still opt in withsetup_propagator=True.CompositePropagator.Without any setup, OTel's default propagators apply (
tracecontext+baggage, or whateverOTEL_PROPAGATORSsays).Unlike the Ruby PR, this doesn't change the default of
setup_otlp_traces_exporter. The spec says it defaults toTrue.Docs (
sentry-docsOTLP page) still need to be updated to describe the new default and manual propagator setup. That isn't part of this PR.Issues
Closes #6732
Closes PY-2574
via Ivana Kellyer.
--
View Session [Sentry]