Repository navigation
fix(toxgen): Preserve caches on --only and --skip - #8240
Merged
Merged
Conversation
Unused cache entries were pruned at the end of every run. Integrations skipped via --only/--skip never access their cache entries, so a partial run wiped most of releases.jsonl and package_dependencies.jsonl. Only prune on full runs.
sentrivana
marked this pull request as ready for review
November 11, 2026 08:58
sentrivana
changed the title
--only and --skip
alexander-alderman-webb
approved these changes
Nov 11, 2026
sentrivana
enabled auto-merge (squash)
November 11, 2026 09:04
Contributor
Coverage Results 📊✅ 137444 passed | ⏭️ 7671 skipped | Total: 145115 | Pass Rate: 94.71% | Execution Time: 454m 56s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 80%). Coverage diff@@ Coverage Diff @@
## master #8240 +/-##
==========================================
Coverage 90.24% 90.24% —%
==========================================
Files 203 203 —
Tracked lines 27114 27114 —
Branches 10136 10136 —
==========================================
- Hits 24469 24468 -1
- Misses 2645 2646 +1
- Partials 1539 1540 +1Generated by Coverage Action |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
QoL improvement to make
--only/--skipmore useful.Running
populate_tox.pywith--only(or--skip) wiped most of the jsonl caches.At the end of each run, both
releases.jsonlandpackage_dependencies.jsonlare rewritten to contain only entries that were accessed during the run. Skipped integrations are read from the existingtox.iniand never touch theirreleases.jsonlentries or their free-threading dependency entries, so all of those got pruned.Now unused entries are only pruned on full runs. Partial runs still sort the files and add newly fetched entries, but don't drop anything. Stale entries for the updated packages stick around until the next full run.