Repository navigation
feat(bedrock): Set gen_ai.input.messages attribute - #8242
Conversation
068a53c to
6ec7171
Compare
Coverage Results 📊✅ 139110 passed | ⏭️ 7765 skipped | Total: 146875 | Pass Rate: 94.71% | Execution Time: 454m 59s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 82.69% (86 of 104 changed executable lines covered; target 80%). Changed files with executable lines (1)
Coverage diff@@ Coverage Diff @@
## master #8242 +/-##
==========================================
Coverage 90.24% 90.24% —%
==========================================
Files 203 203 —
Tracked lines 27125 27229 +104
Branches 10142 10198 +56
==========================================
+ Hits 24478 24571 +93
- Misses 2647 2658 +11
- Partials 1541 1554 +13Generated by Coverage Action |
6ec7171 to
4ce3c03
Compare
4ce3c03 to
bbf0fb1
Compare
sentrivana
left a comment
There was a problem hiding this comment.
Lgtm, see one comment
|
|
||
| if BOTOCORE_VERSION >= Version("1.34.131"): | ||
| messages.append( | ||
| { |
There was a problem hiding this comment.
Are these extra messages the same as in the test above? Can we extract them to constants? Including the whole dicts in the tests makes them hard to read.
There was a problem hiding this comment.
good point, I want to bundle messages and expected transformed messages together so I've made it a fixture.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3172ca7. Configure here.

Transform parts to adhere to the OTel schema, omitting fields in the OTel parts where the information is not available.
https://github.com/open-telemetry/semantic-conventions-genai/blob/main/model/gen-ai/gen-ai-input-messages.json
Skip messages for which OTel does not have a well-defined part type.