Repository navigation
docs(celery): Fix stale comment referencing removed sentry_apply_entry - #8253
Merged
Merged
Conversation
alexander-alderman-webb
approved these changes
Nov 12, 2026
Contributor
Coverage Results 📊✅ 139110 passed | ⏭️ 7765 skipped | Total: 146875 | Pass Rate: 94.71% | Execution Time: 447m 31s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 80%). Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## master #8253 +/-##
==========================================
Coverage 90.24% 90.24% —%
==========================================
Files 203 203 —
Tracked lines 27125 27229 +104
Branches 10142 10198 +56
==========================================
+ Hits 24478 24572 +94
- Misses 2647 2657 +10
- Partials 1541 1554 +13Generated by Coverage Action |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Comment-only change in
sentry_sdk/integrations/celery/__init__.py(_update_celery_task_headers, line 244). No code changes.Old comment:
Why it's stale:
sentry_apply_entryno longer exists. The comment was added in 9fc2f44 (#2993, Apr 2024), whensentry_apply_entrywas the inner wrapper in_patch_beat_apply_entryincelery/beat.py. The Celery Beat refactor in 009fa4f (#3175, reapplying #3105, Jun 2024) removed it. It was replaced by_wrap_beat_scheduler/sentry_patched_scheduler, which call_apply_crons_data_to_schedule_entry. That function now sets thesentry-monitor-slug,sentry-monitor-configandsentry-monitor-check-in-idheaders onschedule_entry.options(sentry_sdk/integrations/celery/beat.py).sentry_apply_entryappears nowhere insentry_sdk/anymore.Fix: The comment still explains why
sentry-*keys get copied into the innerheadersdict, so I kept it and only swapped the function name for_apply_crons_data_to_schedule_entry.Issues
n/a
via automation
sched_7b023adc5c6d74c9739cbbdca1ed3cf8· Run IDsched_7b023adc5c6d74c9739cbbdca1ed3cf8:1794470400000.--
View Session [Sentry]