Skip to content

feat(bedrock): Set gen_ai.response.time_to_first_chunk - #8255

Merged
alexander-alderman-webb merged 15 commits into
masterfrom
webb/bedrock/time-to-first-chunk
Nov 12, 2026
Merged

alexander-alderman-webb merged 15 commits into
masterfrom
webb/bedrock/time-to-first-chunk

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Pet OTel, the duration is computed relative to a start time before the request is sent.
Add a request_start_time instance variable on extensions to propagate the start time into the patched iterator.

Closes #5470

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/bedrock/time-to-first-chunk branch from 07671d4 to 54f6f8a Compare November 12, 2026 08:25

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 139222 passed | ⏭️ 7861 skipped | Total: 147083 | Pass Rate: 94.66% | Execution Time: 461m 11s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +104
Passed Tests 📈 +56
Failed Tests —
Skipped Tests 📈 +48

All tests are passing successfully.

✅ Patch coverage is 94.44% (17 of 18 changed executable lines covered; target 80%).
Project statement coverage is 90.25% (up 0.01 percentage points from base (c877c50) to head (a0dff72)).

Changed files with executable lines (4)
File Patch coverage Changed executable lines
sentry_sdk/integrations/boto3/_services/base.py 66.67% 2/3 covered; missed: 24
sentry_sdk/consts.py 100.00% 2/2 covered
sentry_sdk/integrations/boto3/_client.py 100.00% 3/3 covered
sentry_sdk/integrations/boto3/_services/bedrock.py 100.00% 10/10 covered
Coverage diff
@@            Coverage Diff             @@
##        master     #8255       +/-##
==========================================
+ Coverage    90.24%    90.25%    +0.01%
==========================================
  Files          203       203         —
  Tracked lines     27235     27335      +100
  Branches     10200     10246       +46
==========================================
+ Hits         24577     24670       +93
- Misses        2658      2665        +7
  Partials      1555      1555         —

Generated by Coverage Action

@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/bedrock/time-to-first-chunk branch from 54f6f8a to c71c056 Compare November 12, 2026 08:38

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as draft November 12, 2026 08:42
@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/bedrock/time-to-first-chunk branch from c71c056 to 38a00ab Compare November 12, 2026 08:54
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review November 12, 2026 08:57
Base automatically changed from webb/bedrock/streaming-finish-reasons to master November 12, 2026 10:31

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d74279d. Configure here.

@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/bedrock/time-to-first-chunk branch from d74279d to 3981f4c Compare November 12, 2026 10:46
@alexander-alderman-webb
alexander-alderman-webb merged commit 860a060 into master Nov 12, 2026
173 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/bedrock/time-to-first-chunk branch November 12, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS SDK Agent Support

2 participants