Skip to content

test(django): Strictly order cache spans to avoid flakes #8266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 1 commit into from
Nov 13, 2026
+17 −8
Merged

test(django): Strictly order cache spans to avoid flakes #8266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions tests/integrations/django/test_cache_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,8 +370,6 @@ def test_cache_spans_decorator(
items = capture_items("span")

client.get(reverse("cached_view"))
client.get(reverse("cached_view"))

sentry_sdk.flush()
spans = [item.payload for item in items]
# first_event - cache.get
Expand All @@ -392,6 +390,10 @@ def test_cache_spans_decorator(
)
assert "cache.hit" not in spans[1]["attributes"]
assert spans[1]["attributes"]["cache.item_size"] == 2

client.get(reverse("cached_view"))
sentry_sdk.flush()
spans = [item.payload for item in items]
# second_event - cache.get
assert spans[5]["attributes"]["sentry.op"] == "cache.get"
assert spans[5]["name"].startswith("views.decorators.cache.cache_page.")
Expand Down Expand Up @@ -470,11 +472,8 @@ def test_cache_spans_templatetag(
items = capture_items("span")

client.get(reverse("view_with_cached_template_fragment"))
client.get(reverse("view_with_cached_template_fragment"))

sentry_sdk.flush()
spans = [item.payload for item in items]
assert len(spans) == 5
# first_event - cache.get
assert spans[0]["attributes"]["sentry.op"] == "cache.get"
assert spans[0]["name"].startswith("template.cache.some_identifier.")
Expand All @@ -493,6 +492,12 @@ def test_cache_spans_templatetag(
)
assert "cache.hit" not in spans[1]["attributes"]
assert spans[1]["attributes"]["cache.item_size"] == 51

client.get(reverse("view_with_cached_template_fragment"))
sentry_sdk.flush()
spans = [item.payload for item in items]

assert len(spans) == 5
# second_event - cache.get
assert spans[3]["attributes"]["sentry.op"] == "cache.get"
assert spans[3]["name"].startswith("template.cache.some_identifier.")
Expand Down Expand Up @@ -754,11 +759,9 @@ def test_cache_spans_item_size(
items = capture_items("span")

client.get(reverse("cached_view"))
client.get(reverse("cached_view"))

sentry_sdk.flush()
spans = [item.payload for item in items]
assert len(spans) == 7

assert spans[0]["attributes"]["sentry.op"] == "cache.get"
assert not spans[0]["attributes"]["cache.hit"]
assert "cache.item_size" not in spans[0]["attributes"]
Expand All @@ -771,6 +774,12 @@ def test_cache_spans_item_size(
assert "cache.hit" not in spans[2]["attributes"]
assert spans[2]["attributes"]["cache.item_size"] == 58

client.get(reverse("cached_view"))
sentry_sdk.flush()
spans = [item.payload for item in items]

assert len(spans) == 7

assert spans[4]["attributes"]["sentry.op"] == "cache.get"
assert spans[4]["attributes"]["cache.hit"]
assert spans[4]["attributes"]["cache.item_size"] == 2
Expand Down
Loading