-
-
Notifications
You must be signed in to change notification settings - Fork 366
chore(deps): update React Native to v0.87.0 #6587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f1912e4
98dca52
5014e0b
479a01d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,17 +22,18 @@ | |
| // subpath export, which classic `node` resolution can't follow. Point directly at its types. | ||
| "@sentry/bundler-plugins/babel-plugin": [ | ||
| "./node_modules/@sentry/bundler-plugins/build/types/babel-plugin/index.d.ts" | ||
| ] | ||
| ], | ||
| // RN 0.87 dropped the top-level `types` field from package.json. Classic `node` | ||
| // module resolution can't follow the exports map that now points to `types_generated/`. | ||
| "react-native": ["./node_modules/react-native/types/index.d.ts"] | ||
| }, | ||
| "outDir": "dist", | ||
| "rootDir": "src", | ||
| "lib": [ | ||
| "es7" | ||
| ], | ||
|
Comment on lines
32
to
34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The path mapping for Suggested FixIdentify all Prompt for AI AgentAlso affects:
|
||
| "jsx": "react", | ||
| "types": [ | ||
| "react-native" | ||
| ], | ||
| "types": [], | ||
| "target": "es6", | ||
| "module": "es6", | ||
| "skipLibCheck": true, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,6 @@ | |
| "compilerOptions": { | ||
| "rootDir": ".", | ||
| "jsx": "react", | ||
| "types": ["jest", "react-native"] | ||
| "types": ["jest"] | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| // oxlint-disable-next-line typescript-eslint(triple-slash-reference) | ||
| /// <reference path="../node_modules/react-native/types/index.d.ts" /> |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react and react-test-renderer not updated to match React Native 0.87.0
The file's own comment explicitly requires updating React when bumping React Native; other packages in this repo pin react to 19.2.3 for RN 0.87.0.
Evidence
packages/core/package.jsonlines 92–93 contain the comment: "React version to be compatible with RN" and "When bumping make sure to update the version of react".react-native0.87.0 (e.g.,samples/react-native,performance-tests/TestAppPlain,dev-packages/e2e-tests) pinsreactto19.2.3.react-test-renderershould remain in sync with thereactversion.Identified by Warden · code-review, find-bugs · GSK-GNG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix attempt detected (commit 8a3c0d5)
The commit updates react-native to 0.87.0 in packages/core/package.json but leaves react and react-test-renderer at 19.1.0 instead of the required 19.2.3, so the mismatch persists.
The original issue appears unresolved. Please review and try again.
Evaluated by Warden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix attempt detected (commit 8a0e5ab)
The commit updates packages/core/package.json to React Native 0.87.0 but leaves react and react-test-renderer at 19.1.0 instead of the required 19.2.3, so the mismatch persists.
The original issue appears unresolved. Please review and try again.
Evaluated by Warden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix attempt detected (commit b705ab1)
The commit updates react-native to 0.87.0 in packages/core/package.json but leaves react and react-test-renderer at 19.1.0 instead of the required 19.2.3.
The original issue appears unresolved. Please review and try again.
Evaluated by Warden
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix attempt detected (commit 98dca52)
The commit updates react-native from 0.86.2 to 0.87.0 in packages/core/package.json but leaves react and react-test-renderer at 19.1.0 instead of the required 19.2.3.
The original issue appears unresolved. Please review and try again.
Evaluated by Warden