Repository navigation
Conversation
1 of 3 tasks
wedamija
changed the title
wedamija
force-pushed
the
danf/good-job-crons
branch
from
October 21, 2026 16:12
294957d to
1a4ef34
Compare
Sends check-ins for GoodJob cron entries when the :good_job_cron patch is enabled, using the cron key as the slug and the entry's schedule as the monitor config. Keys can be skipped with config.rails.good_job_exclude_cron_jobs. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
wedamija
force-pushed
the
danf/good-job-crons
branch
from
October 21, 2026 21:43
1a4ef34 to
2fb94f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
This adds a
:good_job_cronpatch to sentry-rails that sends check-ins for every GoodJob cron entry inconfig.good_job.cron. Each cron key becomes a monitor slug, and the entry's cron and time zone are sent as the monitor config. The check-ins wrap each run on the worker, retries included.Schedules Crons can't express, like every 10 seconds, and entries whose
cronis a proc check in without a config. Jobs that already usesentry_monitor_check_insare left alone.The patch is off by default.
good_jobis added as a dev dependency for the specs (Rails 6.1+, Ruby 3.0+).Based on #2751 by @amkisko.
Stacked on #3141.