Repository navigation
ref(k8s): Use arroyo.healthcheck for the pipeline liveness probe - #389
Merged
Merged
Conversation
The pipeline liveness probe ran `rm /tmp/health.txt`, which fails on images without coreutils (distroless/DHI), so the probe would fail and restart every pipeline pod. Remove the file with Python instead. The container command already relies on `python` being on PATH, so this adds no new requirement on the image. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace the inline `python -c "import os; os.remove(...)"` snippet with `python -m arroyo.healthcheck`, which arroyo ships for this probe since 2.46.0. Arroyo's Healthcheck strategy writes /tmp/health.txt, so arroyo should own the check, and its failure message says what went wrong instead of printing a traceback. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oioki
changed the title
…veness-probe Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oioki
marked this pull request as ready for review
November 3, 2026 23:29
untitaker
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the
PipelineStepliveness probe fromrm /tmp/health.txttopython -m arroyo.healthcheck /tmp/health.txt(getsentry/arroyo#580).rmdoesn't exist on distroless images, so there the probe fails and every pipeline pod gets restarted. The new command works on both slim and distroless images.It needs
sentry-arroyo>=2.46in the image. super-big-consumers, the only production user ofsentry-streams-k8s, already runs arroyo 2.47 in every region, so this is safe to merge. After release, bumpsentry-streams-k8sin ops.Refs SEC-1096