Repository navigation
ci(release): Bump craft to 3.9.0 and update config - #412
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the
sentry_streamsrelease workflow's pinnedgetsentry/craftaction from 2.19.0 (c6e2f049, no version comment) to 3.9.0 (2e29b081, now with a# 3.9.0comment), and updates both craft configs to match.Why: craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so the later steps kept going until the cancellation landed. That's how getsentry/symbolic run 41665569364 still prepared a release and opened a getsentry/publish issue while a
release-blockerissue was open. getsentry/craft#956 fixed this in 3.9.0: the step now fails right away, and also fails if the blocker lookup errors.Config changes (
sentry_streams/.craft.ymlandsentry_streams_k8s/.craft.yml):minVersion0.34.1 → 3.9.0.changelogPolicy: autowithchangelog.policy: auto.versioning.policy: manual, which was craft's default belowminVersion2.14.0. Without it, 3.9.0 would default toauto.preReleaseCommandwas already set, so version bumping doesn't change.release-streams-k8s.yaml, which still runsgetsentry/action-prepare-release@v1. I left that workflow alone. That action installs the latest craft release, which is 3.9.0 right now, so the newminVersionworks there too.getsentry/craft:latest, which is 3.9.0 right now, so publishing meets the newminVersion.Compatibility: action inputs only gained new optional ones between 2.19.0 and 3.9.0, so
path: sentry_streamsstays valid. Neither config setschangelog.includePathsorunownedPaths, and there's no nuget target.Dry run: I ran craft 3.9.0
prepare 99.0.0 --dry-run --no-push --no-changelogfrom each package directory, before and after the config change. Both times it ran../scripts/bump-version.shand changed only that package'spyproject.toml, with no errors. After the change, thechangelogPolicydeprecation warning is gone.I used
--no-changelogbecause of a bug in craft 3.9.0's dry run that affects configs in subdirectories. When the changelog gets new entries, the dry run fails withpathspec 'CHANGELOG.md' did not match any files. Its temporary worktree's git client is rooted at the repo root instead of the config directory. A realprepareuses the config directory, so releases aren't affected. This also corrects my earlier note blaming a shallow clone; that was wrong.No open
release-blockerissues in this repo right now. Once this lands, any openrelease-blockerissue will stop releases until it's closed orforceis set.via @BYK.
--
View Session in Sentry