Skip to content

ci(release): Bump craft to 3.9.0 and update config - #412

Open
sentry-junior[bot] wants to merge 2 commits into
mainfrom
ci/bump-craft-3.9.0
Open

sentry-junior[bot] wants to merge 2 commits into
mainfrom
ci/bump-craft-3.9.0

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

This bumps the sentry_streams release workflow's pinned getsentry/craft action from 2.19.0 (c6e2f049, no version comment) to 3.9.0 (2e29b081, now with a # 3.9.0 comment), and updates both craft configs to match.

Why: craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so the later steps kept going until the cancellation landed. That's how getsentry/symbolic run 41665569364 still prepared a release and opened a getsentry/publish issue while a release-blocker issue was open. getsentry/craft#956 fixed this in 3.9.0: the step now fails right away, and also fails if the blocker lookup errors.

Config changes (sentry_streams/.craft.yml and sentry_streams_k8s/.craft.yml):

  • minVersion 0.34.1 → 3.9.0.
  • Replaces the deprecated changelogPolicy: auto with changelog.policy: auto.
  • Adds versioning.policy: manual, which was craft's default below minVersion 2.14.0. Without it, 3.9.0 would default to auto. preReleaseCommand was already set, so version bumping doesn't change.
  • The k8s config is used by release-streams-k8s.yaml, which still runs getsentry/action-prepare-release@v1. I left that workflow alone. That action installs the latest craft release, which is 3.9.0 right now, so the new minVersion works there too.
  • getsentry/publish runs getsentry/craft:latest, which is 3.9.0 right now, so publishing meets the new minVersion.

Compatibility: action inputs only gained new optional ones between 2.19.0 and 3.9.0, so path: sentry_streams stays valid. Neither config sets changelog.includePaths or unownedPaths, and there's no nuget target.

Dry run: I ran craft 3.9.0 prepare 99.0.0 --dry-run --no-push --no-changelog from each package directory, before and after the config change. Both times it ran ../scripts/bump-version.sh and changed only that package's pyproject.toml, with no errors. After the change, the changelogPolicy deprecation warning is gone.

I used --no-changelog because of a bug in craft 3.9.0's dry run that affects configs in subdirectories. When the changelog gets new entries, the dry run fails with pathspec 'CHANGELOG.md' did not match any files. Its temporary worktree's git client is rooted at the repo root instead of the config directory. A real prepare uses the config directory, so releases aren't affected. This also corrects my earlier note blaming a shallow clone; that was wrong.

No open release-blocker issues in this repo right now. Once this lands, any open release-blocker issue will stop releases until it's closed or force is set.

via @BYK.

--

View Session in Sentry

Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@sentry-junior
sentry-junior Bot requested a review from a team as a code owner November 3, 2026 21:08
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@sentry-junior sentry-junior Bot changed the title ci(release): Bump getsentry/craft to 3.9.0 ci(release): Bump craft to 3.9.0 and update config Nov 3, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant