Repository navigation
fix(cli): Report dashboard widget failures through the shared error policy - #1929
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
BYK
requested changes
Nov 4, 2026
BYK
left a comment
Member
There was a problem hiding this comment.
Well, you already know what I'm going to tell you: make sure this can never happen again. My hunch is a lint rule but feel free to use another method if you see fit.
…olicy Widget query failures were sent with a raw captureException, skipping the 4xx silencing rules and the cli_error tags. They now go through reportCliError, and the widget shows the API detail, wrapped to the widget width.
Add the sentry-cli/no-raw-capture-exception lint rule so a raw captureException can't skip the 4xx/network silencing and api_error context again (CLI-10). reportCliError now takes optional tags, extra, and level, and the 18 existing raw call sites use it.
sentry-junior
Bot
force-pushed
the
fix/cli-dashboard-widget-error-reporting
branch
from
November 4, 2026 15:04
e2a3803 to
378d7bd
Compare
…get-error-reporting # Conflicts: # packages/cli/src/lib/dsn/fs-utils.ts
…get-error-reporting # Conflicts: # .oxlintrc.json # packages/cli/AGENTS.md # packages/cli/lint-rules/cli-oxlint-plugin.js
BYK
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentry dashboard viewsent each failed widget query to Sentry with a rawcaptureException. That call skipped the policy inreportCliError, so:ApiErrors are meant to be silenced. One user re-viewing one dashboard produced about 13% of a 300-event sample of CLI-10. Every widget sends its own event.cli_error.*tags and noapi_errorcontext, so they landed in CLI-10 with an empty endpoint and no detail. Another 7% of the sample was this.Widget failures now go through
reportCliError, as its best-effort-catch contract requires. The widget also shows the server'sdetail, wrapped to the widget width. Before, the status line alone filled the widget and was cut off.Before
Sentry received both errors as
ApiError: API request failed: 400 Bad Request/404 Not Found, with no endpoint tag and no detail.After
Sentry now gets the 400 with
cli_error.api_endpointand theapi_errordetail. The 404 is recorded only in thecli.error.silencedmetric.--jsonoutput gets the same detail in the widget'smessage.Keeping it from coming back
A new
sentry-cli/no-raw-capture-exceptionOxlint rule flags anycaptureExceptioninpackages/cli/srcoutsideerror-reporting.ts.reportCliErrornow takes optionaltags,extraandlevel, and the 18 existing raw call sites use it.AGENTS.mddocuments the rule.Before
After
What the migration changes: 401–499
ApiErrors and offline network errors from those best-effort sites now go to thecli.error.silencedmetric instead of becoming issues, for example a 403 when auto-adding yourself to a new team. Grouping stays the same. The project's fingerprint rules key only oncli_error.classfor CLI error classes, and those tags were already set inbeforeSend.via @BYK.
--
View Session [Sentry]