Repository navigation
chore(mcp-cloudflare): Remove unused better-sqlite3 dependency - #1941
Merged
Merged
Conversation
better-sqlite3 was a leftover from early eval scaffolding. Nothing in the workspace imports it, and mcp-cloudflare runs on Workers. Version 11.10.0 has no Node 26 prebuild and fails to compile there, which broke pnpm install on Node 26. With the dependency gone, revert the apps/local engines.node cap from #1933 so the Vercel sentry-local build can use Node 26 again. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BYK
approved these changes
Nov 4, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
better-sqlite3, which is what breakspnpm installon Node 26: v11.10.0 has no Node 26 prebuild and fails to compile from source. Then reverts theapps/localengines.nodecap from #1933, since that cap only worked around this dependency.Why it's safe to drop
packages/mcp-cloudflare(left over from the early eval scaffolding). No source, config, script, or workflow in the repo imports or references it.node:sqlite(ornode-sqlite3-wasmon older Node), not better-sqlite3.@cloudflare/*plugins,agents,workers-mcp, vite, vitest) mentions it. The only hit wasunstorage, which listsbetter-sqlite3@^12as a devDependency, reached through cli-docs/astro.prebuild-install,bindings,tar-fs, …).#1933 revert
apps/local/package.jsonis back to^20.19.0 || >=22.12.0. With better-sqlite3 gone, Node 26 installs cleanly. Locally on Node 26.13.0, Vercel's install command (pnpm install --force --frozen-lockfile) and theapps/localbuild both succeed. This PR'ssentry-localVercel preview should confirm the same.via @BYK.
--
View Session in Sentry