Repository navigation
fix(cli): Show the server's hint for rejected Explore function arguments - #1966
Merged
Merged
Conversation
Read the optional `hint` the server sends with invalid_function_argument 400s (getsentry/sentry#129981) and show it as the suggestion. Drop the CLI's own transaction.duration -> span.duration mapping, which the server now owns. The tags[name,number] / sentry attribute list hint stays as the fallback when the server sends no hint. Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
BYK
approved these changes
Nov 4, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1927 (CLI-10), as decided in this review thread.
The
invalid_function_argument400 can now carry ahint(getsentry/sentry#129981).readErrorFieldsreads it next tofunctionandargument, andsentry exploreshows it as the suggestion. The CLI's owntransaction.duration→span.durationmapping is gone, since the server owns that text now. Thetags[X,number]/sentry attribute listhint names CLI commands and flags, so it stays in the CLI as the fallback when there's nohint.Until sentry#129981 deploys,
transaction.durationgets the generic fallback hint instead of thespan.durationone.Before
After
With the server's
hint:Without it (before sentry#129981 deploys):
via @BYK.
--
View Session [Sentry]