Repository navigation
fix(graph): stack all series when stacked equals label - #44
Open
mguellsegarra wants to merge 1 commit into
Open
mguellsegarra wants to merge 1 commit into
mguellsegarra wants to merge 1 commit into
Conversation
giscebot
approved these changes
Nov 11, 2026
giscebot
left a comment
Contributor
There was a problem hiding this comment.
He revisado el contrato de stacked, el flujo completo de GraphChart.process y la cobertura añadida.
El cambio distingue correctamente los dos significados existentes del atributo:
- si
stackedreferencia un campo distinto delabel, conserva el agrupado dinámico por ambos campos; - si
stacked == label, agrupa una sola vez por la etiqueta y emite el nombre del atributo como stack común, evitando que cada serie acabe en un stack propio.
La regresión reproduce el caso real con varios valores de x y varias etiquetas, y comprueba tanto la separación de series (type) como el stack compartido. El resto de rutas (stack literal, stack por otro campo y series sin label) quedan intactas. También he comprobado diff --check y la CI del SHA 53a7fd9: 154 ejemplos pasan con Python 3.11.
No veo regresiones ni cambios de contrato accidentales. Aprobado.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs gisce/webclient#4323
Since #30, a
stackedattribute that names a field groups series by its value. Whenstackedis the same field aslabel(for examplelabel="name" stacked="name"), every series got its own stack, so bars were drawn side by side withcnc_active - cnc_activelabels instead of stacked.Group by the stacked value only when
stackedis a field other thanlabel. When they match, every series shares the stack named by the attribute. This matches what the webclient processor already returns for the same view.Validation:
label="name" stacked="name". It failed before the change and passes now.