Skip to content

Add JSON grading output to gitmastery verify - #157

Open
jiaxinnns wants to merge 3 commits into
mainfrom
feat/verify-json
Open

jiaxinnns wants to merge 3 commits into
mainfrom
feat/verify-json

Conversation

@jiaxinnns

@jiaxinnns jiaxinnns commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Desktop clients currently parse formatted verification text, which can lose feedback when output arrives in separate stream chunks. gitmastery verify --json returns one JSON object containing exercise_name, status, and all comments, with Python diagnostics on stderr.

Existing text output, grading, progress submission, and exit behavior are preserved. The README documents the option.

Coverage is limited to two focused tests: the JSON result with diagnostic stream separation, and an empty comments array when feedback is absent. The baseline repo has 11 tests across 7 files (1.57 per file). This PR adds no E2E tests.

Test plan

  • uv run python -m pytest tests/test_verify_json.py — 2 passed.
  • Ruff lint and formatting checks passed for the changed test files.
  • Mypy passed for the changed test files.
  • Run the focused tests on Windows and Linux.

Expose grading results for desktop integrations without parsing terminal text while preserving existing verification behavior.
Remove redundant checks of unchanged workflows and exercise JSON persistence through the existing E2E fixtures.
Remove the design document and extra tests to match the repository's small test suites.

This branch is waiting to be deployed

1 waiting deployment
e2e-test — d7bf091b Waiting Nov 10, 2026 by jiaxinnns via E2E Tests (macos-latest) #164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant