Repository navigation
Conversation
Expose grading results for desktop integrations without parsing terminal text while preserving existing verification behavior.
jiaxinnns
requested review from
SAN-MUYUN,
VikramGoyal23,
desmondwong1215 and
jovnc
as code owners
November 9, 2026 04:07
Remove redundant checks of unchanged workflows and exercise JSON persistence through the existing E2E fixtures.
Remove the design document and extra tests to match the repository's small test suites.
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop clients currently parse formatted verification text, which can lose feedback when output arrives in separate stream chunks.
gitmastery verify --jsonreturns one JSON object containingexercise_name,status, and allcomments, with Python diagnostics on stderr.Existing text output, grading, progress submission, and exit behavior are preserved. The README documents the option.
Coverage is limited to two focused tests: the JSON result with diagnostic stream separation, and an empty comments array when feedback is absent. The baseline repo has 11 tests across 7 files (1.57 per file). This PR adds no E2E tests.
Test plan
uv run python -m pytest tests/test_verify_json.py— 2 passed.